diff options
| author | Heinrich Schuchardt <heinrich.schuchardt@canonical.com> | 2022-12-08 04:14:19 +0300 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2022-12-09 08:55:27 +0300 |
| commit | 8b00be692740736e989776b312c87dc9c0b403c8 (patch) | |
| tree | 3c9646a29f7036acbba57886f94126c241b388d8 | |
| parent | ed8b8f5254752b1a7c7b90f61302095eade5b04a (diff) | |
| download | opensbi-8b00be692740736e989776b312c87dc9c0b403c8.tar.xz | |
lib: fix is_region_valid()
For 'reg->order == __riscv_xlen' the term 'BIT(reg->order)' is undefined.
Addresses-Coverity-ID: 1529706 ("Bad bit shift operation")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
| -rw-r--r-- | lib/sbi/sbi_domain.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c index 3302213..3205595 100644 --- a/lib/sbi/sbi_domain.c +++ b/lib/sbi/sbi_domain.c @@ -149,7 +149,7 @@ static bool is_region_valid(const struct sbi_domain_memregion *reg) if (reg->order == __riscv_xlen && reg->base != 0) return FALSE; - if (reg->base & (BIT(reg->order) - 1)) + if (reg->order < __riscv_xlen && (reg->base & (BIT(reg->order) - 1))) return FALSE; return TRUE; |