diff options
| author | Miklos Szeredi <mszeredi@redhat.com> | 2018-11-09 17:52:16 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-21 11:22:10 +0300 |
| commit | a80cb9b673349f65b5ce91661982d4a4fccc2e2e (patch) | |
| tree | d327898cfe17da7da6b4b26c5545d7339f8ae4e8 | |
| parent | e6fed825e0eb63fd8933842aeb827e5e15f8b965 (diff) | |
| download | linux-a80cb9b673349f65b5ce91661982d4a4fccc2e2e.tar.xz | |
fuse: fix leaked notify reply
commit 7fabaf303458fcabb694999d6fa772cc13d4e217 upstream.
fuse_request_send_notify_reply() may fail if the connection was reset for
some reason (e.g. fs was unmounted). Don't leak request reference in this
case. Besides leaking memory, this resulted in fc->num_waiting not being
decremented and hence fuse_wait_aborted() left in a hanging and unkillable
state.
Fixes: 2d45ba381a74 ("fuse: add retrieve request")
Fixes: b8f95e5d13f5 ("fuse: umount should wait for all requests")
Reported-and-tested-by: syzbot+6339eda9cb4ebbc4c37b@syzkaller.appspotmail.com
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> #v2.6.36
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/fuse/dev.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 6be41a210b4d..97f15787cfeb 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1724,8 +1724,10 @@ static int fuse_retrieve(struct fuse_conn *fc, struct inode *inode, req->in.args[1].size = total_len; err = fuse_request_send_notify_reply(fc, req, outarg->notify_unique); - if (err) + if (err) { fuse_retrieve_end(fc, req); + fuse_put_request(fc, req); + } return err; } |