summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorErnesto Corona <ernesto.corona@intel.com>2021-06-02 22:04:24 +0300
committerJae Hyun Yoo <jae.hyun.yoo@intel.com>2021-07-14 20:10:33 +0300
commitdaee5b9f522896762be5c2423a8dc3d5d92a4f07 (patch)
treea511a218b9598ee4ab1dc7eb97a64acc1a764341
parent7457b4915fa27af4c06220b2c903d5a2430dcf28 (diff)
downloadlinux-daee5b9f522896762be5c2423a8dc3d5d92a4f07.tar.xz
ASD Disable JTAG Master controller output when driver is released
To avoid conflicts with other JTAG hardware probes such as XDP, ASD must disable JTAG Master controller output when ASD connection is not in use. This commit fixes the output disable for AST26xx series which needs ASPEED_JTAG_CTRL and ASPEED_JTAG_GBLCTRL to be cleared for all SW, HW1 and HW2 modes. Test: 1. Run jtag_test 2. Run ASD Sanity(using XDP) - Failed here before 3. Run jtag_test 4. Run ASD Sanity(using ASD) 5. Run ASD Sanity(using XDP) - Failed here before 6. ASD Sanity(using ASD) Signed-off-by: Ernesto Corona <ernesto.corona@intel.com> Change-Id: I4f403f4b8412ab96cee195412cc412360845b6d0
-rw-r--r--drivers/jtag/jtag-aspeed.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c
index aeb6502e5a85..727aa0a37c68 100644
--- a/drivers/jtag/jtag-aspeed.c
+++ b/drivers/jtag/jtag-aspeed.c
@@ -330,6 +330,7 @@ static inline void aspeed_jtag_output_disable(struct aspeed_jtag *aspeed_jtag)
static inline void
aspeed_jtag_output_disable_26xx(struct aspeed_jtag *aspeed_jtag)
{
+ aspeed_jtag_write(aspeed_jtag, 0, ASPEED_JTAG_CTRL);
aspeed_jtag_write(aspeed_jtag, 0, ASPEED_JTAG_GBLCTRL);
}