summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIwona Winiarska <iwona.winiarska@intel.com>2020-12-04 03:02:05 +0300
committerIwona Winiarska <iwona.winiarska@intel.com>2020-12-08 22:53:48 +0300
commitf44350611da69f8a8fe9688b8170b726c6e3165c (patch)
tree0684e7be7d2dd22b380ea080fd49e1ac33cb5c4f
parent13e505c41b8c492a08c2cac7e2481f7ae134795c (diff)
downloadlinux-f44350611da69f8a8fe9688b8170b726c6e3165c.tar.xz
fixup! peci: aspeed: add a WA to cover timing negotiation issue
No functional changes, just plain warnings removal: drivers/peci/busses/peci-aspeed.c: In function 'aspeed_peci_init_regs': drivers/peci/busses/peci-aspeed.c:163:1: warning: no return statement in function returning non-void [-Wreturn-type] drivers/peci/busses/peci-aspeed.c: In function 'aspeed_peci_check_idle': drivers/peci/busses/peci-aspeed.c:168:6: warning: unused variable 'ret' [-Wunused-variable] Change-Id: I0a99bf598741bbd7ef00cc9995300c7bb6086e62 Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
-rw-r--r--drivers/peci/busses/peci-aspeed.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/peci/busses/peci-aspeed.c b/drivers/peci/busses/peci-aspeed.c
index 30cb418ea469..9dd3686a4228 100644
--- a/drivers/peci/busses/peci-aspeed.c
+++ b/drivers/peci/busses/peci-aspeed.c
@@ -132,7 +132,7 @@ struct aspeed_peci {
u32 clk_div_val;
};
-static int aspeed_peci_init_regs(struct aspeed_peci *priv)
+static void aspeed_peci_init_regs(struct aspeed_peci *priv)
{
writel(FIELD_PREP(ASPEED_PECI_CTRL_CLK_DIV_MASK,
ASPEED_PECI_CLK_DIV_DEFAULT) |
@@ -165,7 +165,6 @@ static int aspeed_peci_init_regs(struct aspeed_peci *priv)
static inline int aspeed_peci_check_idle(struct aspeed_peci *priv)
{
u32 cmd_sts = readl(priv->base + ASPEED_PECI_CMD);
- int ret;
if (FIELD_GET(ASPEED_PECI_CMD_STS_MASK,
cmd_sts) == ASPEED_PECI_CMD_STS_ADDR_T_NEGO)