diff options
author | Hangyu Hua <hbh25y@gmail.com> | 2022-03-11 11:02:08 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-08 15:24:09 +0300 |
commit | 37f07ad24866c6c1423b37b131c9a42414bcf8a1 (patch) | |
tree | 9ec42e7e3c68c92068a9b58ee00ae4828c0b17ff | |
parent | 7521a97b1929042604bef6859f62fa8b4bbc077b (diff) | |
download | linux-37f07ad24866c6c1423b37b131c9a42414bcf8a1.tar.xz |
can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
commit 04c9b00ba83594a29813d6b1fb8fdc93a3915174 upstream.
There is no need to call dev_kfree_skb() when usb_submit_urb() fails
because can_put_echo_skb() deletes original skb and
can_free_echo_skb() deletes the cloned skb.
Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/net/can/usb/mcba_usb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index a1a154c08b7f..0cf5c6d5e9e4 100644 --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -368,7 +368,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb, xmit_failed: can_free_echo_skb(priv->netdev, ctx->ndx, NULL); mcba_usb_free_ctx(ctx); - dev_kfree_skb(skb); stats->tx_dropped++; return NETDEV_TX_OK; |