summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Skripkin <paskripkin@gmail.com>2021-07-05 23:47:27 +0300
committerGeert Uytterhoeven <geert@linux-m68k.org>2021-07-19 13:20:33 +0300
commit761608f5cf70e8876c2f0e39ca54b516bdcb7c12 (patch)
tree4dff90e41dc001ebf9dca849ebe228e8d41035bc
parent21ed49265986931b8921a2404394426870245bd2 (diff)
downloadlinux-761608f5cf70e8876c2f0e39ca54b516bdcb7c12.tar.xz
m68k: emu: Fix invalid free in nfeth_cleanup()
In the for loop all nfeth_dev array members should be freed, not only the first one. Freeing only the first array member can cause double-free bugs and memory leaks. Fixes: 9cd7b148312f ("m68k/atari: ARAnyM - Add support for network access") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210705204727.10743-1-paskripkin@gmail.com Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
-rw-r--r--arch/m68k/emu/nfeth.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c
index d2875e32abfc..79e55421cfb1 100644
--- a/arch/m68k/emu/nfeth.c
+++ b/arch/m68k/emu/nfeth.c
@@ -254,8 +254,8 @@ static void __exit nfeth_cleanup(void)
for (i = 0; i < MAX_UNIT; i++) {
if (nfeth_dev[i]) {
- unregister_netdev(nfeth_dev[0]);
- free_netdev(nfeth_dev[0]);
+ unregister_netdev(nfeth_dev[i]);
+ free_netdev(nfeth_dev[i]);
}
}
free_irq(nfEtherIRQ, nfeth_interrupt);