diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-11-01 16:14:30 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-11-27 18:12:58 +0300 |
| commit | ad1834fd8a479f499918107e1f97591eb0a4b39f (patch) | |
| tree | 4ce012652af52ef20cfcdb916ae974829368417e /arch | |
| parent | 1beb22c52484f8e4047af142ee70e1b357d561c9 (diff) | |
| download | linux-ad1834fd8a479f499918107e1f97591eb0a4b39f.tar.xz | |
cifs: don't dereference smb_file_target before null check
[ Upstream commit 8c6c9bed8773375b1d54ccca2911ec892c59db5d ]
There is a null check on dst_file->private data which suggests
it can be potentially null. However, before this check, pointer
smb_file_target is derived from dst_file->private and dereferenced
in the call to tlink_tcon, hence there is a potential null pointer
deference.
Fix this by assigning smb_file_target and target_tcon after the
null pointer sanity checks.
Detected by CoverityScan, CID#1475302 ("Dereference before null check")
Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions