summaryrefslogtreecommitdiff
path: root/drivers/atm
diff options
context:
space:
mode:
authorZou Wei <zou_wei@huawei.com>2021-05-12 10:00:24 +0300
committerDavid S. Miller <davem@davemloft.net>2021-05-13 00:03:54 +0300
commit34e7434ba4e97f4b85c1423a59b2922ba7dff2ea (patch)
tree260a3101efb4dc949cbb23e1492062283be14e0c /drivers/atm
parentfaa5f5da809b690542e1108ba66886574ac57d2c (diff)
downloadlinux-34e7434ba4e97f4b85c1423a59b2922ba7dff2ea.tar.xz
atm: nicstar: Fix possible use-after-free in nicstar_cleanup()
This module's remove path calls del_timer(). However, that function does not wait until the timer handler finishes. This means that the timer handler may still be running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling del_timer_sync(), which makes sure the timer handler has finished, and unable to re-schedule itself. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm')
-rw-r--r--drivers/atm/nicstar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index 5c7e4df159b9..b015c3e14336 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -299,7 +299,7 @@ static void __exit nicstar_cleanup(void)
{
XPRINTK("nicstar: nicstar_cleanup() called.\n");
- del_timer(&ns_timer);
+ del_timer_sync(&ns_timer);
pci_unregister_driver(&nicstar_driver);