diff options
| author | Chengfeng Ye <cyeaa@connect.ust.hk> | 2021-11-04 16:46:42 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 13:03:14 +0300 |
| commit | 38a721f609267788bbdbcc8bee3299f3ec8b4428 (patch) | |
| tree | a35dac8addc51b4f0b5fa4570a38528a1994896a /drivers/crypto | |
| parent | 561030c55120893b4d8c939c7891907144fb0bee (diff) | |
| download | linux-38a721f609267788bbdbcc8bee3299f3ec8b4428.tar.xz | |
crypto: qce - fix uaf on qce_skcipher_register_one
[ Upstream commit e9c195aaeed1b45c9012adbe29dedb6031e85aa8 ]
Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.
Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/qce/skcipher.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index 8ff10928f581..3d27cd5210ef 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -484,8 +484,8 @@ static int qce_skcipher_register_one(const struct qce_skcipher_def *def, ret = crypto_register_skcipher(alg); if (ret) { - kfree(tmpl); dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name); + kfree(tmpl); return ret; } |