diff options
| author | Dave Jiang <dave.jiang@intel.com> | 2021-02-01 18:26:14 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-02-03 14:27:12 +0300 |
| commit | 89e3becd8f821e507052e012d2559dcda59f538e (patch) | |
| tree | bf10672138ec53bf2e4db538a6667e374c75bfb0 /drivers/dma/idxd/init.c | |
| parent | fed1b6a00a191cad4dd843519b590e3d6ad9f843 (diff) | |
| download | linux-89e3becd8f821e507052e012d2559dcda59f538e.tar.xz | |
dmaengine: idxd: check device state before issue command
Add device state check before executing command. Without the check the
command can be issued while device is in halt state and causes the driver to
block while waiting for the completion of the command.
Reported-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Tested-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
Fixes: 0d5c10b4c84d ("dmaengine: idxd: add work queue drain support")
Link: https://lore.kernel.org/r/161219313921.2976211.12222625226450097465.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/idxd/init.c')
| -rw-r--r-- | drivers/dma/idxd/init.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index 2c051e07c34c..fa04acd5582a 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -335,7 +335,10 @@ static int idxd_probe(struct idxd_device *idxd) int rc; dev_dbg(dev, "%s entered and resetting device\n", __func__); - idxd_device_init_reset(idxd); + rc = idxd_device_init_reset(idxd); + if (rc < 0) + return rc; + dev_dbg(dev, "IDXD reset complete\n"); if (IS_ENABLED(CONFIG_INTEL_IDXD_SVM)) { |