summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/intel_overlay.c
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2019-06-14 14:10:52 +0300
committerChris Wilson <chris@chris-wilson.co.uk>2019-06-14 14:16:30 +0300
commita09507682e45d62e64c93cdb810de6a280424f17 (patch)
tree98d93f487c6fa7ec80cbe8b3cd27f1e68351324f /drivers/gpu/drm/i915/intel_overlay.c
parent5e3fb2a5b528bbb6090bea3f345eb72d8c8b808d (diff)
downloadlinux-a09507682e45d62e64c93cdb810de6a280424f17.tar.xz
drm/i915: Discard some redundant cache domain flushes
Since commit a679f58d0510 ("drm/i915: Flush pages on acquisition"), we flush objects on acquire their pages and as such when we create an object for the purpose of writing into it, we do not need to manually flush. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190614111053.25615-1-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/intel_overlay.c')
-rw-r--r--drivers/gpu/drm/i915/intel_overlay.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
index a2ac06a08715..21339b7f6a3e 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+++ b/drivers/gpu/drm/i915/intel_overlay.c
@@ -1377,12 +1377,6 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv)
if (ret)
goto out_free;
- i915_gem_object_lock(overlay->reg_bo);
- ret = i915_gem_object_set_to_gtt_domain(overlay->reg_bo, true);
- i915_gem_object_unlock(overlay->reg_bo);
- if (ret)
- goto out_reg_bo;
-
memset_io(overlay->regs, 0, sizeof(struct overlay_registers));
update_polyphase_filter(overlay->regs);
update_reg_attrs(overlay, overlay->regs);
@@ -1391,8 +1385,6 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv)
DRM_INFO("Initialized overlay support.\n");
return;
-out_reg_bo:
- i915_gem_object_put(overlay->reg_bo);
out_free:
kfree(overlay);
}