diff options
| author | Chengfeng Ye <cyeaa@connect.ust.hk> | 2021-11-05 16:45:07 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 13:04:31 +0300 |
| commit | 0c3df095fab62e22b018e1c455f75c25062b4a32 (patch) | |
| tree | b8474d631ce7429ded2c86c21cdc4cdb0d7975d1 /drivers/hsi | |
| parent | 8c124608bf46dc450cbe71dc713aa82159349bd2 (diff) | |
| download | linux-0c3df095fab62e22b018e1c455f75c25062b4a32.tar.xz | |
HSI: core: Fix return freed object in hsi_new_client
[ Upstream commit a1ee1c08fcd5af03187dcd41dcab12fd5b379555 ]
cl is freed on error of calling device_register, but this
object is return later, which will cause uaf issue. Fix it
by return NULL on error.
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hsi')
| -rw-r--r-- | drivers/hsi/hsi_core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index ec90713564e3..884066109699 100644 --- a/drivers/hsi/hsi_core.c +++ b/drivers/hsi/hsi_core.c @@ -102,6 +102,7 @@ struct hsi_client *hsi_new_client(struct hsi_port *port, if (device_register(&cl->device) < 0) { pr_err("hsi: failed to register client: %s\n", info->name); put_device(&cl->device); + goto err; } return cl; |