diff options
| author | Brandon Wyman <bjwyman@gmail.com> | 2022-03-18 02:21:23 +0300 |
|---|---|---|
| committer | Joel Stanley <joel@jms.id.au> | 2022-03-21 05:54:33 +0300 |
| commit | e7265ec49718d7f22c7555c809763771db5db323 (patch) | |
| tree | 469844f9a9f18f8554b0a67f5b7b5622b23ddac0 /drivers/hwmon | |
| parent | 6f7b3b6368f95822756e280ce0d01ef4bbf49294 (diff) | |
| download | linux-e7265ec49718d7f22c7555c809763771db5db323.tar.xz | |
hwmon: (pmbus) Add Vin unit off handling
If there is an input undervoltage fault, reported in STATUS_INPUT
command response, there is quite likely a "Unit Off For Insufficient
Input Voltage" condition as well.
Add a constant for bit 3 of STATUS_INPUT. Update the Vin limit
attributes to include both bits in the mask for clearing faults.
If an input undervoltage fault occurs, causing a unit off for
insufficient input voltage, but the unit is off bit is not cleared, the
STATUS_WORD will not be updated to clear the input fault condition.
Including the unit is off bit (bit 3) allows for the input fault
condition to completely clear.
OpenBMC-Staging-Count: 1
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Link: https://lore.kernel.org/r/20220317232123.2103592-1-bjwyman@gmail.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/pmbus/pmbus.h | 1 | ||||
| -rw-r--r-- | drivers/hwmon/pmbus/pmbus_core.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h index e0aa8aa46d8c..ef3a8ecde4df 100644 --- a/drivers/hwmon/pmbus/pmbus.h +++ b/drivers/hwmon/pmbus/pmbus.h @@ -319,6 +319,7 @@ enum pmbus_fan_mode { percent = 0, rpm }; /* * STATUS_VOUT, STATUS_INPUT */ +#define PB_VOLTAGE_VIN_OFF BIT(3) #define PB_VOLTAGE_UV_FAULT BIT(4) #define PB_VOLTAGE_UV_WARNING BIT(5) #define PB_VOLTAGE_OV_WARNING BIT(6) diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 1b16c03f7f2e..2c7ab58453f4 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -1383,7 +1383,7 @@ static const struct pmbus_limit_attr vin_limit_attrs[] = { .reg = PMBUS_VIN_UV_FAULT_LIMIT, .attr = "lcrit", .alarm = "lcrit_alarm", - .sbit = PB_VOLTAGE_UV_FAULT, + .sbit = (PB_VOLTAGE_UV_FAULT | PB_VOLTAGE_VIN_OFF), }, { .reg = PMBUS_VIN_OV_WARN_LIMIT, .attr = "max", |