summaryrefslogtreecommitdiff
path: root/drivers/input
diff options
context:
space:
mode:
authorRoel Kluin <roel.kluin@gmail.com>2009-02-02 03:54:19 +0300
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2009-02-02 03:58:07 +0300
commitbc34496d63ec0a669d6825ea42275fd6fcbe9969 (patch)
treef2035768ce6f8e307add8da626a5f629f2034545 /drivers/input
parent4e8718a1f960db0c48427f4583f89f4cb62f2480 (diff)
downloadlinux-bc34496d63ec0a669d6825ea42275fd6fcbe9969.tar.xz
Input: pxa930_trkball - fix write timeout handling
With a postfix decrement i reaches -1 rather than 0, but after the loop it is tested whether it has become 0. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/input')
-rw-r--r--drivers/input/mouse/pxa930_trkball.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/mouse/pxa930_trkball.c b/drivers/input/mouse/pxa930_trkball.c
index a0f45c4fc198..784be69b7112 100644
--- a/drivers/input/mouse/pxa930_trkball.c
+++ b/drivers/input/mouse/pxa930_trkball.c
@@ -83,7 +83,7 @@ static int write_tbcr(struct pxa930_trkball *trkball, int v)
__raw_writel(v, trkball->mmio_base + TBCR);
- while (i--) {
+ while (--i) {
if (__raw_readl(trkball->mmio_base + TBCR) == v)
break;
msleep(1);