summaryrefslogtreecommitdiff
path: root/drivers/media
diff options
context:
space:
mode:
authorChen-Yu Tsai <wens@csie.org>2015-12-22 07:27:35 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-03-04 02:07:13 +0300
commit3214cf3b5fbe69b0274cb18a4147f62f926bd7fd (patch)
treec86cc468bf86ec12c90627337dcb9328484634a9 /drivers/media
parentaaf1569ce4575ed163839002f27da2cde4d10a77 (diff)
downloadlinux-3214cf3b5fbe69b0274cb18a4147f62f926bd7fd.tar.xz
rc: sunxi-cir: Initialize the spinlock properly
commit 768acf46e1320d6c41ed1b7c4952bab41c1cde79 upstream. The driver allocates the spinlock but fails to initialize it correctly. The kernel reports a BUG indicating bad spinlock magic when spinlock debugging is enabled. Call spin_lock_init() on it to initialize it correctly. Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver") Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/rc/sunxi-cir.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 7830aef3db45..40f77685cc4a 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
if (!ir)
return -ENOMEM;
+ spin_lock_init(&ir->ir_lock);
+
if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir"))
ir->fifo_size = 64;
else