summaryrefslogtreecommitdiff
path: root/drivers/media
diff options
context:
space:
mode:
authorWenwen Wang <wenwen@cs.uga.edu>2019-08-17 10:04:04 +0300
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-08-22 00:39:54 +0300
commit2f6451ed8b5223a28eab81116dd2f901c0dc9f4a (patch)
tree22c2e04b9bc3b429e2102b82eb4e5af1ea9f278f /drivers/media
parent8c3d3cdbd5dde9bc87d556d2daa9d771ac5254dc (diff)
downloadlinux-2f6451ed8b5223a28eab81116dd2f901c0dc9f4a.tar.xz
media: dvb-frontends: fix a memory leak bug
In cx24117_load_firmware(), 'buf' is allocated through kmalloc() to hold the firmware. However, if i2c_transfer() fails, it is not deallocated, leading to a memory leak bug. Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/dvb-frontends/cx24117.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-frontends/cx24117.c
index 42697a5999f7..9fccc906d85a 100644
--- a/drivers/media/dvb-frontends/cx24117.c
+++ b/drivers/media/dvb-frontends/cx24117.c
@@ -619,8 +619,10 @@ static int cx24117_load_firmware(struct dvb_frontend *fe,
/* send fw */
ret = i2c_transfer(state->priv->i2c, &msg, 1);
- if (ret < 0)
+ if (ret < 0) {
+ kfree(buf);
return ret;
+ }
kfree(buf);