diff options
| author | Zheng Yongjun <zhengyongjun3@huawei.com> | 2022-03-26 11:12:39 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-08 15:23:53 +0300 |
| commit | b375ea083fa649092cd016ac1f89a2d1fd8f8e8b (patch) | |
| tree | 07e6a32bb10965bbd4cb37258f9365dd1a4a48f7 /drivers/net/ethernet/microchip | |
| parent | 409570a619c1cda2e0fde6018a256b9e3d3ba0ee (diff) | |
| download | linux-b375ea083fa649092cd016ac1f89a2d1fd8f8e8b.tar.xz | |
net: sparx5: switchdev: fix possible NULL pointer dereference
[ Upstream commit 0906f3a3df07835e37077d8971aac65347f2ed57 ]
As the possible failure of the allocation, devm_kzalloc() may return NULL
pointer.
Therefore, it should be better to check the 'db' in order to prevent
the dereference of NULL pointer.
Fixes: 10615907e9b51 ("net: sparx5: switchdev: adding frame DMA functionality")
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/microchip')
| -rw-r--r-- | drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c index 7436f62fa152..174ad95e746a 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c @@ -420,6 +420,8 @@ static int sparx5_fdma_tx_alloc(struct sparx5 *sparx5) db_hw->dataptr = phys; db_hw->status = 0; db = devm_kzalloc(sparx5->dev, sizeof(*db), GFP_KERNEL); + if (!db) + return -ENOMEM; db->cpu_addr = cpu_addr; list_add_tail(&db->list, &tx->db_list); } |