summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/moxa
diff options
context:
space:
mode:
authorPavel Skripkin <paskripkin@gmail.com>2021-07-09 17:09:53 +0300
committerDavid S. Miller <davem@davemloft.net>2021-07-09 21:01:01 +0300
commitc78eaeebe855fd93f2e77142ffd0404a54070d84 (patch)
tree417e6a280a7c901151ca223b6c1d224e3277acac /drivers/net/ethernet/moxa
parent2b452550a203d88112eaf0ba9fc4b750a000b496 (diff)
downloadlinux-c78eaeebe855fd93f2e77142ffd0404a54070d84.tar.xz
net: moxa: fix UAF in moxart_mac_probe
In case of netdev registration failure the code path will jump to init_fail label: init_fail: netdev_err(ndev, "init failed\n"); moxart_mac_free_memory(ndev); irq_map_fail: free_netdev(ndev); return ret; So, there is no need to call free_netdev() before jumping to error handling path, since it can cause UAF or double-free bug. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/moxa')
-rw-r--r--drivers/net/ethernet/moxa/moxart_ether.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 5249b64f4fc5..49def6934cad 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -540,10 +540,8 @@ static int moxart_mac_probe(struct platform_device *pdev)
SET_NETDEV_DEV(ndev, &pdev->dev);
ret = register_netdev(ndev);
- if (ret) {
- free_netdev(ndev);
+ if (ret)
goto init_fail;
- }
netdev_dbg(ndev, "%s: IRQ=%d address=%pM\n",
__func__, ndev->irq, ndev->dev_addr);