summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/moxa
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2020-04-26 23:59:21 +0300
committerDavid S. Miller <davem@davemloft.net>2020-05-01 06:23:49 +0300
commitee8d2267f0e39a1bfd95532da3a6405004114b27 (patch)
tree726a218a5c59fb3b2109012c4bfe193576c4f770 /drivers/net/ethernet/moxa
parentab046a5d4be4c90a3952a0eae75617b49c0cb01b (diff)
downloadlinux-ee8d2267f0e39a1bfd95532da3a6405004114b27.tar.xz
net: moxa: Fix a potential double 'free_irq()'
Should an irq requested with 'devm_request_irq' be released explicitly, it should be done by 'devm_free_irq()', not 'free_irq()'. Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/moxa')
-rw-r--r--drivers/net/ethernet/moxa/moxart_ether.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index e1651756bf9d..f70bb81e1ed6 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -564,7 +564,7 @@ static int moxart_remove(struct platform_device *pdev)
struct net_device *ndev = platform_get_drvdata(pdev);
unregister_netdev(ndev);
- free_irq(ndev->irq, ndev);
+ devm_free_irq(&pdev->dev, ndev->irq, ndev);
moxart_mac_free_memory(ndev);
free_netdev(ndev);