summaryrefslogtreecommitdiff
path: root/drivers/of
diff options
context:
space:
mode:
authorMichal Suchanek <hramrach@gmail.com>2016-06-26 23:11:58 +0300
committerRob Herring <robh@kernel.org>2016-07-19 01:18:36 +0300
commit5de3bbc8501b637eb753e4ee18a2cccb233cfe41 (patch)
treef6f8d87b870a4ee352a58af517aa80cf5fdbe7a4 /drivers/of
parent4b681efc027821ad601fc76b6cdb25e95575449f (diff)
downloadlinux-5de3bbc8501b637eb753e4ee18a2cccb233cfe41.tar.xz
of: overlay: add resolver error prints
Applying overlay fails silently in case of an error. Add error prints. Most notably the lack of symbols in the live tree is not reported. Signed-off-by: Michal Suchanek <hramrach@gmail.com> Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/resolver.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 741461142984..46325d6394cf 100644
--- a/drivers/of/resolver.c
+++ b/drivers/of/resolver.c
@@ -315,6 +315,11 @@ int of_resolve_phandles(struct device_node *resolve)
phandle phandle, phandle_delta;
int err;
+ if (!resolve)
+ pr_err("%s: null node\n", __func__);
+ if (resolve && !of_node_check_flag(resolve, OF_DETACHED))
+ pr_err("%s: node %s not detached\n", __func__,
+ resolve->full_name);
/* the resolve node must exist, and be detached */
if (!resolve || !of_node_check_flag(resolve, OF_DETACHED))
return -EINVAL;
@@ -371,6 +376,7 @@ int of_resolve_phandles(struct device_node *resolve)
/* we need to fixup, but no root symbols... */
if (!root_sym) {
+ pr_err("%s: no symbols in root of device tree.\n", __func__);
err = -EINVAL;
goto out;
}