summaryrefslogtreecommitdiff
path: root/drivers/of
diff options
context:
space:
mode:
author권오훈 <ohoono.kwon@samsung.com>2021-07-01 17:04:57 +0300
committerRob Herring <robh@kernel.org>2021-07-15 16:35:49 +0300
commiteb7173988caf6fc68ef00065b9defb5ac3467f21 (patch)
tree10e718e32e5fe7d6c62cd16bee915856d4ff64d5 /drivers/of
parentace1c4b5c412d21b41329c723acce248a503bad4 (diff)
downloadlinux-eb7173988caf6fc68ef00065b9defb5ac3467f21.tar.xz
of: fdt: remove unnecessary codes
While unflattening the device tree, we try to populate dt nodes and properties into tree-shaped data structure. In populate_properties function, pprev is initially set to &np->properties, and then updated to &pp->next. In both scenarios *pprev is NULL, since the memory area that we are allocating from is initially zeroed. I tested the code as below, and it showed that BUG was never called. - if (!dryrun) + if (!dryrun) { + if (*pprev) + BUG(); *pprev = NULL; + } Let's remove unnecessary code. Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com> Link: https://lore.kernel.org/r/20210701140457epcms1p2cc43a7c62150f012619feab913f017af@epcms1p2 Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/fdt.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index e0f96e3ef1da..bd35ba56aa96 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -200,9 +200,6 @@ static void populate_properties(const void *blob,
nodename, (char *)pp->value);
}
}
-
- if (!dryrun)
- *pprev = NULL;
}
static int populate_node(const void *blob,