summaryrefslogtreecommitdiff
path: root/drivers/pci/pci-sysfs.c
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2017-01-14 03:05:12 +0300
committerBjorn Helgaas <bhelgaas@google.com>2017-01-31 01:55:33 +0300
commitcdcb33f9824429a926b971bf041a6cec238f91ff (patch)
tree05668a16f75570f3a408b762ea2462180cb26a30 /drivers/pci/pci-sysfs.c
parent53762ba810398c11efaf65f9a45d992125e86dcf (diff)
downloadlinux-cdcb33f9824429a926b971bf041a6cec238f91ff.tar.xz
PCI: Avoid possible deadlock on pci_lock and p->pi_lock
pci_lock is an IRQ-safe spinlock that protects all accesses to PCI configuration space (see PCI_OP_READ() and PCI_OP_WRITE() in pci/access.c). The pci_cfg_access_unlock() path acquires pci_lock, then p->pi_lock (inside wake_up_all()). According to lockdep, there is a possible path involving snbep_uncore_pci_read_counter() that could acquire them in the reverse order: acquiring p->pi_lock, then pci_lock, which could result in a deadlock. Lockdep details are in the bugzilla below. Avoid the possible deadlock by dropping pci_lock before waking up any config access waiters. Link: https://bugzilla.kernel.org/show_bug.cgi?id=192901 Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci/pci-sysfs.c')
0 files changed, 0 insertions, 0 deletions