diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-01-12 14:17:24 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-16 14:56:22 +0300 |
| commit | 94b16ca86ab688ed6fad4548f70137f93cf1f0a9 (patch) | |
| tree | 78233e846d3f288960e2e5f240fcd71f0b85b2cd /drivers/phy | |
| parent | 541ec7bfeed36a74b47ea8b440da0591ea05d555 (diff) | |
| download | linux-94b16ca86ab688ed6fad4548f70137f93cf1f0a9.tar.xz | |
phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()
[ Upstream commit cfc826c88a79e22ba5d8001556eb2c7efd8a01b6 ]
This error path needs to decrement "usbphyc->n_pll_cons.counter" before
returning.
Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220112111724.GB3019@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/st/phy-stm32-usbphyc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 937a14fa7448..da05642d3bd4 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -225,7 +225,7 @@ static int stm32_usbphyc_pll_enable(struct stm32_usbphyc *usbphyc) ret = __stm32_usbphyc_pll_disable(usbphyc); if (ret) - return ret; + goto dec_n_pll_cons; } ret = stm32_usbphyc_regulators_enable(usbphyc); |