summaryrefslogtreecommitdiff
path: root/drivers/ras
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2019-04-20 22:33:08 +0300
committerBorislav Petkov <bp@suse.de>2019-06-08 18:34:36 +0300
commit5cc6b16ea1313d05956b55e83a1f753c604282a8 (patch)
tree0ea40140c969393c91d33f5379306f0cd57267e6 /drivers/ras
parentde0e0624d86ff9fc512dedb297f8978698abf21a (diff)
downloadlinux-5cc6b16ea1313d05956b55e83a1f753c604282a8.tar.xz
RAS/CEC: Do not set decay value on error
When the value requested doesn't match the allowed (min,max) range, the @data buffer should not be modified with the invalid value because reading "decay_interval" shows it otherwise as if the previous write succeeded. Move the data write after the check. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Tony Luck <tony.luck@intel.com> Cc: linux-edac <linux-edac@vger.kernel.org>
Diffstat (limited to 'drivers/ras')
-rw-r--r--drivers/ras/cec.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 73a975c26f9f..31868bd99e8d 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -371,17 +371,17 @@ DEFINE_DEBUGFS_ATTRIBUTE(pfn_ops, u64_get, pfn_set, "0x%llx\n");
static int decay_interval_set(void *data, u64 val)
{
- *(u64 *)data = val;
-
if (val < CEC_DECAY_MIN_INTERVAL)
return -EINVAL;
if (val > CEC_DECAY_MAX_INTERVAL)
return -EINVAL;
+ *(u64 *)data = val;
decay_interval = val;
cec_mod_work(decay_interval);
+
return 0;
}
DEFINE_DEBUGFS_ATTRIBUTE(decay_interval_ops, u64_get, decay_interval_set, "%lld\n");