diff options
| author | Voon Weifeng <weifeng.voon@intel.com> | 2020-09-23 11:56:14 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-09-24 04:08:06 +0300 |
| commit | 7241c5a697479c7d0c5a96595822cdab750d41ae (patch) | |
| tree | 83aee7049275699cb67398d4f2b0d4a4533174f9 /include | |
| parent | f9317ae5523f99999fb54c513ebabbb2bc887ddf (diff) | |
| download | linux-7241c5a697479c7d0c5a96595822cdab750d41ae.tar.xz | |
net: stmmac: removed enabling eee in EEE set callback
EEE should be only be enabled during stmmac_mac_link_up() when the
link are up and being set up properly. set_eee should only do settings
configuration and disabling the eee.
Without this fix, turning on EEE using ethtool will return
"Operation not supported". This is due to the driver is in a dead loop
waiting for eee to be advertised in the for eee to be activated but the
driver will only configure the EEE advertisement after the eee is
activated.
Ethtool should only return "Operation not supported" if there is no EEE
capbility in the MAC controller.
Fixes: 8a7493e58ad6 ("net: stmmac: Fix a race in EEE enable callback")
Signed-off-by: Voon Weifeng <weifeng.voon@intel.com>
Acked-by: Mark Gross <mgross@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions