diff options
| author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2022-03-17 17:51:32 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-13 21:59:27 +0300 |
| commit | ff6505766565616deb65a203e62d4ca63c6c277b (patch) | |
| tree | 764a8caa3f25ac965878c0760c6e0f92ac26d987 /kernel | |
| parent | f399f38eda5779fe90f0620024197f74a45012c0 (diff) | |
| download | linux-ff6505766565616deb65a203e62d4ca63c6c277b.tar.xz | |
sched: Teach the forced-newidle balancer about CPU affinity limitation.
commit 386ef214c3c6ab111d05e1790e79475363abaa05 upstream.
try_steal_cookie() looks at task_struct::cpus_mask to decide if the
task could be moved to `this' CPU. It ignores that the task might be in
a migration disabled section while not on the CPU. In this case the task
must not be moved otherwise per-CPU assumption are broken.
Use is_cpu_allowed(), as suggested by Peter Zijlstra, to decide if the a
task can be moved.
Fixes: d2dfa17bc7de6 ("sched: Trivial forced-newidle balancer")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/YjNK9El+3fzGmswf@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sched/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c51bd3692316..779f3198b17d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5927,7 +5927,7 @@ static bool try_steal_cookie(int this, int that) if (p == src->core_pick || p == src->curr) goto next; - if (!cpumask_test_cpu(this, &p->cpus_mask)) + if (!is_cpu_allowed(p, this)) goto next; if (p->core_occupation > dst->idle->core_occupation) |