summaryrefslogtreecommitdiff
path: root/lib/refcount.c
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-04-13 18:13:29 +0300
committerSteve French <stfrench@microsoft.com>2018-04-17 22:44:30 +0300
commit0d568cd34eb04acf05c26f360d1a0f071f0bb636 (patch)
treea044c5c68f8451cf9f87e3fea4b6d1272bd12750 /lib/refcount.c
parenta27fc14219f2e3c4a46ba9177b04d9b52c875532 (diff)
downloadlinux-0d568cd34eb04acf05c26f360d1a0f071f0bb636.tar.xz
cifs: smb2ops: Fix NULL check in smb2_query_symlink
The current code null checks variable err_buf, which is always null when it is checked, hence utf16_path is free'd and the function returns -ENOENT everytime it is called, making it impossible for the execution path to reach the following code: err_buf = err_iov.iov_base; Fix this by null checking err_iov.iov_base instead of err_buf. Also, notice that err_buf no longer needs to be initialized to NULL. Addresses-Coverity-ID: 1467876 ("Logically dead code") Fixes: 2d636199e400 ("cifs: Change SMB2_open to return an iov for the error parameter") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Steve French <smfrench@gmail.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Diffstat (limited to 'lib/refcount.c')
0 files changed, 0 insertions, 0 deletions