diff options
author | Philip Pettersson <philip.pettersson@gmail.com> | 2016-12-01 01:55:36 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-12-02 20:16:49 +0300 |
commit | 84ac7260236a49c79eede91617700174c2c19b0c (patch) | |
tree | 6f3e90bdd39cffbcdec28e6b84314b10e3dc2de3 /net/ipv4/ip_output.c | |
parent | 2219d5ed77e8bdc2ef1f0b79f34d2cc0be802b25 (diff) | |
download | linux-84ac7260236a49c79eede91617700174c2c19b0c.tar.xz |
packet: fix race condition in packet_set_ring
When packet_set_ring creates a ring buffer it will initialize a
struct timer_list if the packet version is TPACKET_V3. This value
can then be raced by a different thread calling setsockopt to
set the version to TPACKET_V1 before packet_set_ring has finished.
This leads to a use-after-free on a function pointer in the
struct timer_list when the socket is closed as the previously
initialized timer will not be deleted.
The bug is fixed by taking lock_sock(sk) in packet_setsockopt when
changing the packet version while also taking the lock at the start
of packet_set_ring.
Fixes: f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation.")
Signed-off-by: Philip Pettersson <philip.pettersson@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_output.c')
0 files changed, 0 insertions, 0 deletions