summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorYajun Deng <yajun.deng@linux.dev>2021-08-30 12:16:40 +0300
committerDavid S. Miller <davem@davemloft.net>2021-08-30 14:47:09 +0300
commit1b9fbe813016b08e08b22ddba4ddbf9cb1b04b00 (patch)
tree0f631551e02b508d17c243b805bb7d0dac8e7aba /net
parentaaa8e4922c887ff47ad66ef918193682bccc1905 (diff)
downloadlinux-1b9fbe813016b08e08b22ddba4ddbf9cb1b04b00.tar.xz
net: ipv4: Fix the warning for dereference
Add a if statements to avoid the warning. Dan Carpenter report: The patch faf482ca196a: "net: ipv4: Move ip_options_fragment() out of loop" from Aug 23, 2021, leads to the following Smatch complaint: net/ipv4/ip_output.c:833 ip_do_fragment() warn: variable dereferenced before check 'iter.frag' (see line 828) Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Fixes: faf482ca196a ("net: ipv4: Move ip_options_fragment() out of loop") Link: https://lore.kernel.org/netdev/20210830073802.GR7722@kadam/T/#t Signed-off-by: Yajun Deng <yajun.deng@linux.dev> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/ip_output.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 9a8f05d5476e..9bca57ef8b83 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -825,7 +825,9 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb,
/* Everything is OK. Generate! */
ip_fraglist_init(skb, iph, hlen, &iter);
- ip_options_fragment(iter.frag);
+
+ if (iter.frag)
+ ip_options_fragment(iter.frag);
for (;;) {
/* Prepare header of the next frame,