summaryrefslogtreecommitdiff
path: root/samples/vfs
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@redhat.com>2020-05-14 17:44:24 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2020-05-14 17:44:24 +0300
commit581701b7efd60ba13d8a7eed60cbdd7fefaf6696 (patch)
tree505b03b9796a3ca2e62743571305d263809a1a3a /samples/vfs
parent44a3b87444058b2cb055092cdebc63858707bf66 (diff)
downloadlinux-581701b7efd60ba13d8a7eed60cbdd7fefaf6696.tar.xz
uapi: deprecate STATX_ALL
Constants of the *_ALL type can be actively harmful due to the fact that developers will usually fail to consider the possible effects of future changes to the definition. Deprecate STATX_ALL in the uapi, while no damage has been done yet. We could keep something like this around in the kernel, but there's actually no point, since all filesystems should be explicitly checking flags that they support and not rely on the VFS masking unknown ones out: a flag could be known to the VFS, yet not known to the filesystem. Cc: David Howells <dhowells@redhat.com> Cc: linux-api@vger.kernel.org Cc: linux-man@vger.kernel.org Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'samples/vfs')
-rw-r--r--samples/vfs/test-statx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/samples/vfs/test-statx.c b/samples/vfs/test-statx.c
index a3d68159fb51..76c577ea4fd8 100644
--- a/samples/vfs/test-statx.c
+++ b/samples/vfs/test-statx.c
@@ -216,7 +216,7 @@ int main(int argc, char **argv)
struct statx stx;
int ret, raw = 0, atflag = AT_SYMLINK_NOFOLLOW;
- unsigned int mask = STATX_ALL;
+ unsigned int mask = STATX_BASIC_STATS | STATX_BTIME;
for (argv++; *argv; argv++) {
if (strcmp(*argv, "-F") == 0) {