summaryrefslogtreecommitdiff
path: root/scripts/modules-check.sh
diff options
context:
space:
mode:
authorMasahiro Yamada <masahiroy@kernel.org>2021-03-31 16:38:05 +0300
committerMasahiro Yamada <masahiroy@kernel.org>2021-04-24 23:22:42 +0300
commit1a998be620a10000c1e1240026e4bd6bc3378c96 (patch)
tree43b11c0ce0134689314cb40e03b361d0bfa730e5 /scripts/modules-check.sh
parent3ac42b2112532a71125eea6bb07361deeca9aaa1 (diff)
downloadlinux-1a998be620a10000c1e1240026e4bd6bc3378c96.tar.xz
kbuild: check module name conflict for external modules as well
If there are multiple modules with the same name in the same external module tree, there is ambiguity about which one will be loaded, and very likely something odd is happening. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/modules-check.sh')
-rwxr-xr-xscripts/modules-check.sh4
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/modules-check.sh b/scripts/modules-check.sh
index 43de226071ae..e06327722263 100755
--- a/scripts/modules-check.sh
+++ b/scripts/modules-check.sh
@@ -13,10 +13,10 @@ exit_code=0
# Check uniqueness of module names
check_same_name_modules()
{
- for m in $(sed 's:.*/::' $1 | sort | uniq -d)
+ for m in $(sed 's:.*/::' "$1" | sort | uniq -d)
do
echo "error: the following would cause module name conflict:" >&2
- sed -n "/\/$m/s:^: :p" modules.order >&2
+ sed -n "/\/$m/s:^: :p" "$1" >&2
exit_code=1
done
}