diff options
author | David S. Miller <davem@davemloft.net> | 2011-01-06 00:08:06 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-01-06 22:38:19 +0300 |
commit | 09798eb9479da3413bdf96e7d22a84d8b21e05e1 (patch) | |
tree | 75e7b1d5475d3ab72bbc0f1d306718800523e604 /scripts | |
parent | 050855887236701c5e7ff803b42265824ce99885 (diff) | |
download | linux-09798eb9479da3413bdf96e7d22a84d8b21e05e1.tar.xz |
atyfb: Fix bootup hangs on sparc64.
After commit 25edd6946a1d74e5e77813c2324a0908c68bcf9e ("sparc64: Get
rid of indirect p1275 PROM call buffer.") we can't pass virtual
addresses >4GB to PROM calls.
Largely this is never necessary in drivers because we have a copy of
the entire PROM device tree in the kernel and a set of of_*()
interfaces to access it.
Unfortunately there were some lingering prom calls in the atyfb
driver, in particular prom_finddevice() was being called with an
on-stack address which could be anywhere.
This code is actually probing for information we already have, the
PROM choosen console output device is stored in of_console_device so
all of this nasty code consolidates into a one-line comparison.
Next we have some prom_getintdefault() calls which are trivially
transformed into the equivalent of_getintprop_default().
Special thanks to Fabio, who figured out exactly where the bootup
was hanging. That made this bug trivial to fix.
Reported-by: Fabio M. Di NItto <fabbione@fabbione.net>
Reported-by: Sam Ravnborg <sam@ravnborg.org>
Reported-by: Frans van Berckel <fberckel@xs4all.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Fabio M. Di NItto <fabbione@fabbione.net>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions