diff options
author | Takashi Iwai <tiwai@suse.de> | 2018-08-01 17:37:02 +0300 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2018-08-01 23:54:36 +0300 |
commit | 00976ad5271999ba06d24319fd1031b178aff832 (patch) | |
tree | 0c88e68218eafd09b3d2b85179ab13fb199f34b6 /sound/core/seq/seq_clientmgr.c | |
parent | fc4bfd9a35f3d9cbf5ad6a20faedca71d1d9ed52 (diff) | |
download | linux-00976ad5271999ba06d24319fd1031b178aff832.tar.xz |
ALSA: seq: Fix leftovers at probe error path
The sequencer core module doesn't call some destructors in the error
path of the init code, which may leave some resources.
This patch mainly fix these leaks by calling the destructors
appropriately at alsa_seq_init(). Also the patch brings a few
cleanups along with it, namely:
- Expand the old "if ((err = xxx) < 0)" coding style
- Get rid of empty seq_queue_init() and its caller
- Change snd_seq_info_done() to void
Last but not least, a couple of functions lose __exit annotation since
they are called also in alsa_seq_init().
No functional changes but minor code cleanups.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/seq/seq_clientmgr.c')
-rw-r--r-- | sound/core/seq/seq_clientmgr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/seq/seq_clientmgr.c b/sound/core/seq/seq_clientmgr.c index 6fd4b074b206..a0b768e2f697 100644 --- a/sound/core/seq/seq_clientmgr.c +++ b/sound/core/seq/seq_clientmgr.c @@ -2543,7 +2543,7 @@ int __init snd_sequencer_device_init(void) /* * unregister sequencer device */ -void __exit snd_sequencer_device_done(void) +void snd_sequencer_device_done(void) { snd_unregister_device(&seq_dev); put_device(&seq_dev); |