summaryrefslogtreecommitdiff
path: root/sound/parisc
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2021-06-08 17:05:40 +0300
committerTakashi Iwai <tiwai@suse.de>2021-06-09 18:30:39 +0300
commit6ea9a2b84cc354ffd028195edb4e3d60d47f7bcb (patch)
tree7efd715d61e909e96cc096f8cad635e73edf6496 /sound/parisc
parentdd1431e53515e5760c03975a0a35aef75924a66d (diff)
downloadlinux-6ea9a2b84cc354ffd028195edb4e3d60d47f7bcb.tar.xz
ALSA: parisc: Fix assignment in if condition
PARISC harmony driver code contains an assignment in if condition, which is a bad coding style that may confuse readers and occasionally lead to bugs. This patch is merely for coding-style fixes, no functional changes. Link: https://lore.kernel.org/r/20210608140540.17885-67-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/parisc')
-rw-r--r--sound/parisc/harmony.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c
index f2ca0a701987..1440db8b4177 100644
--- a/sound/parisc/harmony.c
+++ b/sound/parisc/harmony.c
@@ -915,10 +915,9 @@ snd_harmony_create(struct snd_card *card,
spin_lock_init(&h->mixer_lock);
spin_lock_init(&h->lock);
- if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL,
- h, &ops)) < 0) {
- goto free_and_ret;
- }
+ err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, h, &ops);
+ if (err < 0)
+ goto free_and_ret;
*rchip = h;