summaryrefslogtreecommitdiff
path: root/tools/gpio
diff options
context:
space:
mode:
authorKent Gibson <warthog618@gmail.com>2020-07-08 07:15:59 +0300
committerBartosz Golaszewski <bgolaszewski@baylibre.com>2020-07-12 11:22:01 +0300
commite890678f6949e848720c66620c390d5e876149a6 (patch)
tree8c064a618dc5eb898d4059ca03628f4a94f0b991 /tools/gpio
parentef3c61a082c86a20cc1a4382142d480655b3c5a1 (diff)
downloadlinux-e890678f6949e848720c66620c390d5e876149a6.tar.xz
tools: gpio: fix spurious close warning in gpio-utils
Fix bogus close warning that occurs when opening the character device fails. Signed-off-by: Kent Gibson <warthog618@gmail.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'tools/gpio')
-rw-r--r--tools/gpio/gpio-utils.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
index 06003789e7c7..16a5d9cb9da2 100644
--- a/tools/gpio/gpio-utils.c
+++ b/tools/gpio/gpio-utils.c
@@ -75,7 +75,7 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
ret = -errno;
fprintf(stderr, "Failed to open %s, %s\n",
chrdev_name, strerror(errno));
- goto exit_close_error;
+ goto exit_free_name;
}
for (i = 0; i < nlines; i++)
@@ -94,9 +94,9 @@ int gpiotools_request_linehandle(const char *device_name, unsigned int *lines,
"GPIO_GET_LINEHANDLE_IOCTL", ret, strerror(errno));
}
-exit_close_error:
if (close(fd) == -1)
perror("Failed to close GPIO character device file");
+exit_free_name:
free(chrdev_name);
return ret < 0 ? ret : req.fd;
}