summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorLorenz Bauer <lmb@cloudflare.com>2020-10-12 12:18:50 +0300
committerDaniel Borkmann <daniel@iogearbox.net>2020-10-15 21:49:56 +0300
commitf58423aeab28f861b67933206f322f764f05787d (patch)
treeeb606d94e8041a53fea006c6db698f0d1788c1b3 /tools
parente688c3db7ca69bea1872c5706aec6a7fdf89df17 (diff)
downloadlinux-f58423aeab28f861b67933206f322f764f05787d.tar.xz
bpf, sockmap: Add locking annotations to iterator
The sparse checker currently outputs the following warnings: include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit Add the necessary __acquires and __release annotations to make the iterator locking schema palatable to sparse. Also add __must_hold for good measure. The kernel codebase uses both __acquires(rcu) and __acquires(RCU). I couldn't find any guidance which one is preferred, so I used what is easier to type out. Fixes: 0365351524d7 ("net: Allow iterating sockmap and sockhash") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Lorenz Bauer <lmb@cloudflare.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Jakub Sitnicki <jakub@cloudflare.com> Link: https://lore.kernel.org/bpf/20201012091850.67452-1-lmb@cloudflare.com
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions