diff options
| author | Artem Senichev <a.senichev@yadro.com> | 2020-07-30 10:11:58 +0300 |
|---|---|---|
| committer | Andrew Geissler <geissonator@yahoo.com> | 2020-07-31 17:08:26 +0300 |
| commit | cdf93992a448c3ab44149c05721eca9ecf0a8de9 (patch) | |
| tree | 828ec94b3339c7a83ed62c01276433600f5da2a9 /meta-yadro/meta-nicole | |
| parent | debf182b63d3577e9a64b99849c1999108082fcb (diff) | |
| download | openbmc-cdf93992a448c3ab44149c05721eca9ecf0a8de9.tar.xz | |
meta-nicole: Fix SRESET over NMI call
Current implementation by IBM supports only witherspoon platform.
This patch makes it possible to use a D-Bus call for initiating kernel
crash (System Reset vector) on the Nicole host system.
(From meta-yadro rev: 5f76189ed4eb64e20191fe460f00f803b37ed88c)
Signed-off-by: Artem Senichev <a.senichev@yadro.com>
Change-Id: I8ef5ecfd209860500f8303a594636a1cff1298a3
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Diffstat (limited to 'meta-yadro/meta-nicole')
2 files changed, 62 insertions, 0 deletions
diff --git a/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch b/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch new file mode 100644 index 000000000..c763e67de --- /dev/null +++ b/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control/0001-Stop-and-send-SRESET-for-one-thread-only.patch @@ -0,0 +1,60 @@ +From 53241d7be35fba23079504468090d770d4116831 Mon Sep 17 00:00:00 2001 +From: Artem Senichev <a.senichev@yadro.com> +Date: Tue, 28 Jul 2020 17:38:17 +0300 +Subject: [PATCH] Stop and send SRESET for one thread only + +Fixes bugs preventing the host from creating a crash dump. + +Stopping all threads leads to errors in skiboot: +[ 163.237293219,3] Could not stop thread 0:0:1: Thread is quiesced already. +If the kernel has xmon support, exiting the debugger causes the kernel +to hang: +[ 235.694220] watchdog: CPU 97 TB:187362511366, last heartbeat TB:159120095297 (55160ms ago) +[ 235.694276] watchdog: CPU 101 Hard LOCKUP + +Sending SRESET to all threads causes kernel panic: +[ 50.495727] Kernel panic - not syncing: Unrecoverable nested System Reset + +Signed-off-by: Artem Senichev <a.senichev@yadro.com> +--- + nmi_interface.cpp | 14 +++++++++++--- + 1 file changed, 11 insertions(+), 3 deletions(-) + +diff --git a/nmi_interface.cpp b/nmi_interface.cpp +index fcce451..d022d7e 100644 +--- a/nmi_interface.cpp ++++ b/nmi_interface.cpp +@@ -38,7 +38,7 @@ void NMI::nMI() + using InternalFailure = + sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure; + +- struct pdbg_target* target; ++ struct pdbg_target* target = nullptr; + + pdbg_for_each_class_target("thread", target) + { +@@ -51,11 +51,19 @@ void NMI::nMI() + report<InternalFailure>(); + return; + } ++ break; + } + +- if (thread_sreset_all() < 0) ++ if (!target) + { +- log<level::ERR>("Failed to sreset all threads"); ++ log<level::ERR>("Thread not found"); ++ report<InternalFailure>(); ++ return; ++ } ++ ++ if (thread_sreset(target) < 0) ++ { ++ log<level::ERR>("Failed to sreset thread"); + report<InternalFailure>(); + } + } +-- +2.27.0 + diff --git a/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control_%.bbappend b/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control_%.bbappend new file mode 100644 index 000000000..ed1cec767 --- /dev/null +++ b/meta-yadro/meta-nicole/recipes-phosphor/host/op-proc-control_%.bbappend @@ -0,0 +1,2 @@ +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" +SRC_URI += "file://0001-Stop-and-send-SRESET-for-one-thread-only.patch" |