Age | Commit message (Collapse) | Author | Files | Lines |
|
To allow thermal modes to be selected at BMC standby, the fan control
application must be running. The phosphor-fan-control@.service file is
needed to start fan control at BMC standby and the
phosphor-fan-control-init@.service is no longer required.
Tested:
Witherspoon phosphor-fan-control@.service replaced in image
phosphor-fan-control-init@.service removed from image
fan watchdog configs appended to fan control service still
phosphor-fan-control@.service started at BMC standby
fan control thermal modes presented/changeable at BMC standby
no function change in configured thermal modes
(From meta-ibm rev: f59761e1af85b3ae6432bf0297f5cfe5be71e557)
Change-Id: I4a946f58b6f0c22ebd402304ae9d8fd17a197571
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Most of mihawk's sensors are different from witherspoon, so I temporarily
added the mihawk part and did not change the witherspoon.
Add mihawk version of fan control and d-bus monitor.
Mihawk does not have a water cooled mode, so another independent folder is added.
Tested: 1.Shut down the system if more than three cores
have a temperature greater than 100 degrees Celcius.
2.Fan control support cpu core, dimm, Onboard.
3.Confirm that sensor is able to return normally via REST.
(From meta-ibm rev: 949f91431bba2f0139cc823d674a741f9590c885)
Signed-off-by: Ben Pai <Ben_Pai@wistron.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: Icc401f32c67b622f0f1448e1166112e02c135a8f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Use an override in bbappends in meta-witherspoon as described and
recommended in the "following best practices when creating layers"
section of the the Yocto development tasks manual.
ibm-ac-server represents common machine configuration shared by all of
IBMs "Accelerated Compute" class of servers. Apply it wherever any
variables are un-bounded by any override.
This enables more flexible use of meta-witherspoon in build
configurations, and easy addition of machines to the layer.
(From meta-ibm rev: bb0e1d0699a4b9905c053c94af7d882cd71779fc)
Change-Id: I82f7338b0d7a64b5e7a67e19bcdff07f48a332d4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
With updates from openbmc/openbmc#2911, event actions are now able to be
configured with groups subsets and event timers are now included in the
available event triggers. Actions with group subsets allow a single
event's set of triggers to run actions against a given group subset
instead of the entire event groups. Also, with timers being included as
a trigger, events can be configured with or without a timer instead of a
disabled timer being created for events that previously did not require
a timer.
Tested:
Generated code is functionally equivalent to previous yaml
Verified fan control functionality of wspoon image
(From meta-ibm rev: 1a43941fb100db7c46430f0dbbc82799276e9c13)
Change-Id: Ide4167ef1a202381b702b7f6fe58b7f30501ecb3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
This allows upstream to drop some backward-incompatible changes while
the yaml in meta-ibm gets updated to the new format coming in from
upstream.
(From meta-ibm rev: 81ca4572471629b5114a52afb50a84d9e2cc92d1)
Change-Id: Ia554f14c624d236e02d7898d2f95e7a90384dadf
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
meta-phosphor recently enabled target class config recipes. Those are
preferable to native class config recipes because native recipes cannot
be overridden based on MACHINE, so switch to target class config
recipes.
Switching to target class recipes consists of temporarily setting
PHOSPHOR_FAN_CONFIG_USE_NATIVE_SYSROOT to 0, overriding the phosphor
distro default of 1. After all OpenBMC BSP layers have moved to target
class config recipes PHOSPHOR_FAN_CONFIG_USE_NATIVE_SYSROOT can be
removed from meta-phosphor and any BSP layers.
Any references to -native recipes are replaced with their target class
counterparts.
Any -native bbappends are re-worked to apply to their target class
counterparts.
Finally, use BPN instead of PN when setting FILESEXTRAPATHS, to avoid
unfortunate directory hierarchies if these bbappends are copy/pasted and
then used to bbappend a native recipe. Since this patch moves to target
class recipes, this is a noop; however, this avoids unfortunate
directory hierarchies with native bbappends such as:
meta-base/recipes-foo/bar/baz-native.bb
meta-base/recipes-foo/bar/baz/a-file
meta-append/recipes-foo/bar/baz-native.bbappend
meta-append/recipes-foo/bar/baz-native/b-file
Using "${THISDIR}/${BPN}:" enables a more sensible hierarchy:
meta-base/recipes-foo/bar/baz-native.bb
meta-base/recipes-foo/bar/baz/a-file
meta-append/recipes-foo/bar/baz-native.bbappend
meta-append/recipes-foo/bar/baz/b-file
This behavior occurs because By default FILESPATH is set in base.bbclass
(in OE-Core) to look for files in ${BP}, ${BPN} and files (and a number
of subdirectories of those based on ${FILESOVERRIDES}).
(From meta-ibm rev: 6587e6ca03ca50411bc11cf87b5e11971dfe343f)
Change-Id: Ib2c3f0052c1e01a84416da2eb868a54d8810e750
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Typically it does not make any sense to append to FILESEXTRAPATHS.
FILESEXTRAPATHS is set in a bbappend when overriding something from
another layer. The typical desire will be to make bitbake search for
files in the layer with the bbappend and not some other layer earlier in
the priority list. Further, appending to FILESEXTRAPATHS will introduce
unexpected behavior when multiple layers append the same recipe - layers
with higher layer priorities that append to FILESEXTRAPATHS will find
their files overriden by files in layers with lower priorities.
(From meta-ibm rev: a588016cb556b425a00286ace2c8324590aac98b)
Change-Id: I7672219fdab5e2c9cc03423d7f507ef2e6a842c2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Yocto automatically adds files/<MACHINE>/ to the file path, take
advantage of this feature to simplify the recipe and directory
structure.
Tested: Built witherspoon, witherspoon-128, and swift, and verified
they all had the correct fans files in their image.
(From meta-ibm rev: 1c8b9d845092ccb6440fc9241993ac3d4db9c2d6)
Change-Id: I2dfa0b04dfba68311d67af10ccfa979f733e630f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Swift fails to build because fan-presence is a dependency for
fan-control, and fan-monitor is a dependency for inventory.
So add them in swift with an empty yaml file. Also fix the
FILESEXTRAPATHS_append to have the colon at the beginning
(vs prepend where colon goes at the end) to be able to find
the files in the right order.
Tested: Built swift successfully.
(From meta-ibm rev: 2493fdb38e1fe8e1488ea1bcc5c723c788d92bae)
Change-Id: Ie41caf90a15c3c33ef49ce03ce1890ca9f0c7289
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
To support the swift system bring-up, install the cooling type and fan
control application with minimal configuration to run fans at full
speed(9500 RPMs).
Tested:
Cooling type included in image and configured correctly
Fan control included in image and configured correctly
(From meta-ibm rev: 2eb5a13421e2c5e5bc0a0cfac9de87f0cd8c9c59)
Change-Id: I3359cf0444c1b4af8fae1b7f51ef608e4dc2c4c2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
In preparation for additional systems under the witherspoon layer, add
the machine name as a prefix to the phosphor-fan* configuration
directories. This allows additional machines' phosphor-fan*
configurations to be placed in this layer.
Tested:
Witherspoon phosphor-fan image still contains applications &
phosphor-fan applications are correctly configured.
(From meta-ibm rev: a63359eebc376e3340bdbc34fc4c83410172a5ae)
Change-Id: I9d711cb68e4563e5a2c6dc88d12d2071364bf8ae
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Patrick Venture (1):
build: install into bin instead of sbin
meta-ibm: phosphor-fan: grab cooling-type from bindir
The output binaries from phosphor-fan-presence are now installed into
bin instead of sbin.
Change-Id: I2d42f62b4535775ffd0d1b9473375dd8dc66bb61
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Patrick Venture <venture@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Instead of obmc-standby.target, use multi-user.target.
(From meta-ibm rev: 85cff8cc9e66049d8ac26271c13f82d894ac572f)
Change-Id: I03c3d41c031343fa584511889c70e3def92cb83d
Signed-off-by: Patrick Venture <venture@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Out of the box bitbake examines built applications, automatically adds
runtime dependencies and thus ensures any library packages dependencies
are automatically added to images, sdks, etc. There is no need to list
them explicitly in a recipe.
Dependencies change over time, and listing them explicitly is likely
prone to errors - the net effect being unnecessary shared library
packages being installed into images.
Consult
https://www.yoctoproject.org/docs/latest/mega-manual/mega-manual.html#var-RDEPENDS
for information on when to use explicit runtime dependencies.
(From meta-ibm rev: fa99caa61ecd28325e9070f268a51a5b52363bc4)
Change-Id: Icc97d4b33635caf127a17e70ba6c23f1367eb735
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
The intent of the wildcards was to match the base recipe
irrespective of version but you don't need the wildcard
to do that. Simply use the recipe name without the version
to match any version of the base recipe.
With the wildcards phosphor-fan%.bbappend for instance
matched every recipe that starts with phosphor-fan causing
strange build warnings like:
invalid packageconfig cooling-type
while building some of the native fan configuration recipes.
Tested: Built a Witherspoon image
(From meta-ibm rev: 56b4d017ce31e686694eb0b304acd6bb9a1d460e)
Change-Id: I83549464086178956405096dcec2729235e4897f
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|