Age | Commit message (Collapse) | Author | Files | Lines |
|
The dependency is required to be the base name of the service file path,
otherwise we see:
```
Jan 01 00:00:33 p10bmc systemd[1]: /lib/systemd/system/obmc-led-set-all-groups-asserted@.service:3: Failed to add dependency on xyz.openbmc_project.LED.GroupManager, ignoring: Invalid argument
Jan 01 00:00:33 p10bmc systemd[1]: /lib/systemd/system/obmc-led-set-all-groups-asserted@.service:4: Failed to add dependency on xyz.openbmc_project.LED.GroupManager, ignoring: Invalid argument
```
Change-Id: Ide813cb3298e7f815b5f42b82473ab2a434193f7
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
These virtual physical LEDs are a mirror of real enclosure fault
and enclosure Identify physical LEDs. However, these virtual LEDs
are needed to be able to communicate the effective state of the
enclosure fault and enclosure identify LEDs during lamp test.
During lamp test, real physical enclosure fault and enclosure id
LEDs should not be updated and they must be updated only after
the lamp test finishes. However, Hypervisors would need to know
the effective state of enclosure level fault and identify
LEDs and that problem is resolved by these virtual LEDs.
Once the lamp test finishes, these virtual physical LEDs would again
be in sync with real enclosure fault and Identify LEDs.
Tests:
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree
xyz.openbmc_project.LED.Controller.virtual_enc_fault
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/led
└─/xyz/openbmc_project/led/physical
└─/xyz/openbmc_project/led/physical/virtual_enc_fault
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree
xyz.openbmc_project.LED.Controller.virtual_enc_id
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/led
└─/xyz/openbmc_project/led/physical
└─/xyz/openbmc_project/led/physical/virtual_enc_id
root@bmc:/lib/systemd/system/multi-user.target.wants#
busctl get-property xyz.openbmc_project.LED.Controller.virtual_enc_fault
/xyz/openbmc_project/led/physical/virtual_enc_fault
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl
set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group
Asserted b true
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property
xyz.openbmc_project.LED.Controller.virtual_enc_id
/xyz/openbmc_project/led/physical/virtual_enc_id
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.On"
root@bmc:/lib/systemd/system/multi-user.target.wants# busctlset-property
xyz.openbmc_project.LED.GroupManager
/xyz/op_ebmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group
Asserted b false
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property
xyz.openbmc_project.LED.Controller.virtual_enc_id
/xyz/openbmc_project/led/physical/virtual_enc_id
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"
Change-Id: Ic0ee5b0f376911650d5489d8bb84a4e83247190f
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
led-set-all-groups-asserted.sh needs to be called with "false"
as part of below transitions to turn off all indicator LEDs
- BMC booting to standby and staying at standby
- BMC starting to power on
(From meta-ibm rev: e784b71c2d625b4507758df4bb5743fc678251f3)
Change-Id: If248220964c65e91e9382504b1a7095cc5cec26b
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|