Age | Commit message (Collapse) | Author | Files | Lines |
|
The repository supports it, so switch it over in bitbake.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8d96c79b395ee2614ddd869091569f245426c5c7
|
|
This variable was added to bitbake.conf so lets use it. Using it is
best pratice and enables things like alternative base_libdir paths.
Change-Id: I9adcec7856c6242d86f0ffad8646a23219ccca21
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Starting with a link to the 4u file. The only difference between the two
is 2 less fans so there should be no real impact to the callout file.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iae528ef6378fdcad524faeefcd6139a1d8223789
|
|
Now that entity manager provides the system name, name the Rainier 2U
device callouts file after it and add the Rainier 4U device callouts
file.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I95ba6cee167616ec01bd7779e88defc0e77810df
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Patrick Williams (2):
bootstrap: fix shellcheck warnings
MAINTAINERS: remove Deepak
Change-Id: Id06241aa091d2c8f16b0f18383e244924030b12f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
The hostboot team has started utilizing VUART1 for extra debug data
during a boot. This extra debug data is enabled within the CI
infrastructure. This extra debug data causes the critical information
going to VUART0 to get wrapped out of the default
/var/log/obmc_console.log file. Redirect the VUART1 data to its own
/var/log/ file.
The only other user of VUART1 on p10bmc systems is the PHYP software.
That is mostly used for interactive purposes so writing its data to a
separate log file should be fine.
I will work with the test teams to ensure this new file is collected as
a part of the standard debug data collection process.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I248e5e8536e58e137b5de35d7572789215566763
|
|
The 1s4u hardware is configured with fans at 0,1,2, and 4 locations.
Tested:
- Verified that we can now power on a 1s4u machine with this change plus
a kernel device tree change to move to fan 4.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ic1415da9ab900c0e553600df89a1e26893f8b0bd
|
|
Bad VPD plugin is an IBM specific plugin which collects all the
corrupted VPD files from /tmp/bad-vpd and puts it as a part of user
initiated BMC dump.
Openpower-vpd-parser makes a copy of the corrupted vpd's into
/tmp/bad-vpd at runtime, whenever there occurs a VPD ECC exception or
VPD record/keyword data exception.
Installed badvpd plugin in dreport via phosphor-debug-collector recipe.
Placed badvpd plugin in
openbmc/phosphor-debug-collector/tools/dreport/ibm.d directory as we
collect bad vpds' only when "ibm-parser" feature flag is enabled.
Tested on simics.
root@rainier:~# dreport -v
Wed Mar 3 04:43:18 UTC 2021 Name: obmcdump_00000000_1614746598.tar.xz
Wed Mar 3 04:43:18 UTC 2021 Epochtime: 1614746598
Wed Mar 3 04:43:18 UTC 2021 ID: 00000000
Wed Mar 3 04:43:18 UTC 2021 Type: user
Wed Mar 3 04:43:18 UTC 2021 INFO: Collected disk usage
Wed Mar 3 04:43:18 UTC 2021 INFO: Collected failed services
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Journal pretty log
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Memory info /proc/meminfo
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected top
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Bad VPD /tmp/bad-vpd
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OS release info /etc/os-release
Wed Mar 3 04:43:19 UTC 2021 INFO: No elog entries
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected inventory
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OBMC console log /var/log/obmc-console.log
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip addr
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip link
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected PRI-Flash: U-Boot environment variables
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied GUARD Records /var/lib/phosphor-software-manager/pnor/prsv/GUARD
Wed Mar 3 04:43:19 UTC 2021 ERROR: /etc/alt_fw_env.config does not exist
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied CPU info /proc/cpuinfo
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected uptime
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected BMC State
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Chassis State
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected hostnamectl
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Host State
Adding Dump Header :/usr/share/dreport.d/include.d/gendumpheader
Wed Mar 3 04:44:08 UTC 2021 Report is available in /tmp
Wed Mar 3 04:44:08 UTC 2021 Successfully completed
Check the dump tar file generated in /tmp directory.
After skipping 628 bytes of dump header in tar, untar it.
The files in /tmp/bad-vpd directory gets collected into the bmc dump.
Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: Ifdbfa56b8c67263271059dbee390092b92977775
|
|
Specifically kdump is a product requirement; makedumpfile is required
to reduce the size of the crash dump image as well as not saving
unneeded data at some point it will be useful from a privacy
perspective by not saving "sensitive" information.
Smaller crash dumps are faster to save thus allowing the reboot
to normal BMC mode sooner.
Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: Ib07690cd26e519e1e3e51013ac76e623a3dad6a9
|
|
The OBMC_ORG_YAML_SUBDIRS variable is intended to be set system-wide
and not via bbappends. There was an existing 'ibm-distrovars.inc'
that was unused. Rename it as appropriate, add it to the machines,
and remove the bbappend files.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id5acd359f41c17ec9e68d1f0717e2f5c1bf96dcf
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I8dece8c720fd520de7a6857a7311b62a65c054ba
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
Commit f7b1f26 removed fru-fault-monitor from Rainier since the
idea then was to have PEL daemon set the Asserted property of
LED Group Object that is mapping to the Inventory D-Bus object.
However, that was not accepted by the community and we now have
a new way of monitoring faults.
With the new way, when monitor-operational-status feature is
enabled, fru-fault-monitor will watch Functional property of
xyz.openbmc_project.State.Decorator.OperationalStatus interface
and sets the Asserted property of appropriate LED Group D-Bus
objects that is mapped via "fault_led_group" association with
the Inventory D-Bus object.
When monitor-operational-status feature is enabled,
fru-fault-monitor will not monitor the OBMC events and would
only watch OperationalStatus. This is done because these 2
features will result in conflicting end result on the LEDs.
Change-Id: I739b5fc261b0c79d50a8dc34ab19a3e108e84edc
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
Currently, the phosphor-fru-fault-monitor updates the Asserted
property of the Led Group D-Bus object by monitoring the
`/xyz/openbmc_project/logging` object path.
The intent behind this commit is to add another way to monitor the
`xyz.openbmc_project.State.Decorator.OperationalStatus` interface
of the Inventory D-Bus object, and check whether the Inventory
D-Bus object is associated with the LED group D-Bus object, and
then update the Asserted property of the LedManager.
Since both these methods handle the faults differently,
Only ONE of these 2 methods can be enabled and NOT both.
The first way is supported by default. To turn OFF the default way
AND turn ON this second way, Enable monitor-operational-status.
Change-Id: I03701e599b6a120bc1f83da6f473b12f38660d64
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
This allows a power button press to power on the system. Rainier and
Everest use the same GPIO.
Tested: Button was pressed and the system booted.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ib8f373dda2adb5575f2a0001d986962e5430fba5
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Verified the rainier build included the expected service files
and LED override file, example:
- rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-led-manager/lamp-test-led-overrides.json
Change-Id: I8f9ecbc6ebe1d320a649b24bf71c5023cfc035c8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Built rainier and verified files were installed:
rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-inventory-manager/ibm,everest_associations.json
rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-inventory-manager/ibm,rainier-4u_associations.json
rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-inventory-manager/ibm,rainier-2u_associations.json
Change-Id: I422374d25966e731147eebd1772d5cfc4f62f9d9
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Built rainier and verified the fan files were installed, ex:
obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-fan-presence/control/ibm,rainier-4u/zones.json
obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-fan-presence/control/ibm,rainier-2u/zones.json
obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-fan-presence/control/ibm,everest/zones.json
Change-Id: I10edb9e30716cffa3f510fe94822eadb08326912
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I0a265a7eb9d763a8385a7139dae47bf2f475c672
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I0ab8ca402117e6eae8508d3f27cac7ad8c8b8aca
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Built rainier and verified that the mboxd service file had 64M:
$ cat tmp/work/rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/lib/systemd/system/mboxd.service
..
ExecStart=/usr/bin/env mboxd --flash 64M --window-size 1M
Change-Id: I7c5bf66ac38ab0b97efa1eba7ceccba86565ed85
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: Ic76f6202f9ae43440e5e6a793ca835a45d6ab088
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I5e0b884b405f56da7aa746b059d2490a1de2caab
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I5b7b173bd0255fcbe1956042cc365bf1fb6c7520
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I43d08c3be45d8cc8b03914b9bc257df2668e9fe0
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: If32498a59ce621b1e456fdf0ec965c92d646ab86
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I7bfbbf2310be78a2ae601047710204f5fb9f0da0
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Built rainier and verified the console files were installed:
rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/etc/obmc-console/
Change-Id: Ida1010ae6c6c0e1eecf2b62521c06bfe055b0d88
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I3947988f73e601ca281b6222a6116bc7f50c8c32
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: Id9cbde5f3ccc505635c37c8ffd92efef191e9320
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I9fa2bb6f199144816bd9d90405afe4fba36fc575
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: Iba75dcfe5eee66bcb0afb5a01feddbf26b2c7988
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Change-Id: I430e6ed6bf006a114e185d4adb507d1c5c6e2cd4
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The IBM rainier machine name is being replaced with the generic p10bmc.
Tested: Built rainier and verified the files were installed as expected:
rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/etc/default/obmc/gpio/phosphor-power-supply-0.conf
Change-Id: I6539c71cfc37fa67027204b17c68a0c7f8fec5a6
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
These virtual physical LEDs are a mirror of real enclosure fault
and enclosure Identify physical LEDs. However, these virtual LEDs
are needed to be able to communicate the effective state of the
enclosure fault and enclosure identify LEDs during lamp test.
During lamp test, real physical enclosure fault and enclosure id
LEDs should not be updated and they must be updated only after
the lamp test finishes. However, Hypervisors would need to know
the effective state of enclosure level fault and identify
LEDs and that problem is resolved by these virtual LEDs.
Once the lamp test finishes, these virtual physical LEDs would again
be in sync with real enclosure fault and Identify LEDs.
Tests:
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree
xyz.openbmc_project.LED.Controller.virtual_enc_fault
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/led
└─/xyz/openbmc_project/led/physical
└─/xyz/openbmc_project/led/physical/virtual_enc_fault
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree
xyz.openbmc_project.LED.Controller.virtual_enc_id
└─/xyz
└─/xyz/openbmc_project
└─/xyz/openbmc_project/led
└─/xyz/openbmc_project/led/physical
└─/xyz/openbmc_project/led/physical/virtual_enc_id
root@bmc:/lib/systemd/system/multi-user.target.wants#
busctl get-property xyz.openbmc_project.LED.Controller.virtual_enc_fault
/xyz/openbmc_project/led/physical/virtual_enc_fault
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl
set-property xyz.openbmc_project.LED.GroupManager
/xyz/openbmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group
Asserted b true
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property
xyz.openbmc_project.LED.Controller.virtual_enc_id
/xyz/openbmc_project/led/physical/virtual_enc_id
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.On"
root@bmc:/lib/systemd/system/multi-user.target.wants# busctlset-property
xyz.openbmc_project.LED.GroupManager
/xyz/op_ebmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group
Asserted b false
root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property
xyz.openbmc_project.LED.Controller.virtual_enc_id
/xyz/openbmc_project/led/physical/virtual_enc_id
xyz.openbmc_project.Led.Physical State
s "xyz.openbmc_project.Led.Physical.Action.Off"
Change-Id: Ic0ee5b0f376911650d5489d8bb84a4e83247190f
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
phosphor-led-manager has 3 packages
- phosphor-led-manager : Default
- phosphor-led-manager-ledmanager : Packages phosphor-ledmanager
- phosphor-ledmanager-faultmonitor : Packages phosphor-fru-fault-monitor
Because of this, it was not possible to install files via Makefile and
that always needed a corresponding update to FILES_{PN}-ledmanager.
Removing phosphor-led-manager-ledmanager will eliminate this problem.
Change-Id: I00ca4c34346a47f887872464b9050a46d8f5e8e9
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
This commit adds below forward and reverse associations
"rType": "fault_inventory_object",
"fType": "fault_led_group"
"rType": "identify_inventory_object",
"fType": "identify_led_group"
Change-Id: Icaad89e6e690c3c0a635362e8c604874bc3f37fe
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
The 1s4u is just like the 2s4u except it has two less fans.
Tested:
- Booted up system with entity-manager loading rainier-1s4u config and
verified fan applications found and loaded new 1s4u files and system
was able to chassis power on.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I575a63edb242c1b94e1a6f1eafd86a96e4518e37
|
|
The 1s4u is just like the 2s4u except it has two less fans.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I56ed73ee573df250072bd014a0e4c8a4072e974e
|
|
The 1s4u is just like the 2s4u except it has two less fans.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I35333e49c883fb9ac8c84223545fe3b903a66d7d
|
|
The 1s4u is just like the 2s4u except it has two less fans. Thermal
profiling may change some of the variable but for now just use the same
as the 2s4u.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iab3fd9d1699de779c242bb42456d976697b4da14
|
|
For implementing kdump Witherspoon-Tacoma and Rainier kexec is needed.
This was done by pulling kexec-tools package into the build.
Tested: I successfully build each Witherspoon-Tacoma and Rainier
booted each in QEMU and manually verified kexec with no parameters
showed the version and help. Presently the kernel's SMP is missing
HOTPLUG so further testing of kexec utility is not possible.
Signed-off-by: Bruce Mitchell <Bruce.Mitchell@ibm.com>
Change-Id: I253dd3e0c46987070b5c252dcd5ab6008b3b09d3
|
|
This commit enables phosphor-ledmanager to do lamp test
Change-Id: I4933ec034911198f99ae1289f681f15057310c33
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
This enables phosphor-ledmanager to use JSON configuration file
Change-Id: I3cbd0bf6b60e81f9f0a479ad51dab438c708c6c1
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
- We have already made the change to make the snooping
port optional, which means that snoopd daemon can still
run and host the interfaces & Postcode Raw Value property
even on the systems with no snooping port.
- The intent behind this commit is to over ride the snoop-device
name to empty from the meta-ibm layer so that the snoopd daemon
will run without the support for snooping port on ibm machines.
Tested:
- Build images for witherspoon-tacoma & rainier, and made sure the
snoopd service runs without any issues.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I622a903f9084a9b94561c1202f8c637d30062112
|
|
For installing gendumpheader plugin, the recipe was including
all files from tools/dreport.d/ibm.d.
Corrected it to take only gendumpheader plugin so that it wont conflict
with installation of other plugins from same directory.
Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I5a1358f07aba6997cb9ae84dba59b3420c7ce968
|
|
The firmware code in these power supplies takes about 1500 milliseconds
to boot after they are inserted, and the presence line goes active.
Until the firmware has completely booted, the power supplies will not
respond to the I2C traffic initiated by the BMC device driver code as it
attempts to probe the hardware.
Adding in a DRIVER_BIND_DELAY_MS environment variable, set to 1500
(milliseconds), to delay the device driver binding in order to hold off
the probe until the power supply firmware should be ready, in order to
avoid ENXIO errors.
Change-Id: I101f8e3b7ff1c2c9e76df758c4551c7793006266
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
|
|
- The intent behind this commit is to pull the snooping daemon
into tacoma & rainier.
- This daemon is used for hosting the necessary dbus interface
& Raw Value property for the pldm to write the progress codes
into.
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I4730046a40345d74d53b19a5058e8e45d2d40e8f
|
|
The phosphor-inventory-manager application supports creating
associations based on JSON files, where the JSON files have conditions
built into them that say which inventory-manager property values are
required for the associations files to be valid.
Add minimal associations files for the Rainier 2U, Rainier 4U, and
Everest systems that just contain the fan inventory associations for
now. The condition is the 'IM' property on the com.ipzvpd.VSBP
interface on the system/chassis/motherboard path.
Change-Id: Ib6807d8982a2efeb94692b917804c53965d6c98a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
Now that phosphor-fan-monitor starts at multi-user instead of the
fans-ready target, it needs a JSON config option to let it know when to
start monitoring after the fans have ramped up.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If8eef303ee585dd30b3fbe9764a624eeab3b1a8a
|
|
Moved "inherit native" statements to the last position to remove QA Issues.
The message is: WARNING: QA Issue: {RECIPENAME}: native/nativesdk class is not
inherited last, this can result in unexpected behaviour. Classes inherited
after native/nativesdk: {CLASSFILES} [native-last]
Tested: The witherspoon image builds without the warnings.
Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net>
Change-Id: Ic3c71234abfcac8b26478bc32808e3bec8bba810
|