Age | Commit message (Collapse) | Author | Files | Lines |
|
Zane Shelley (4):
scope hei_bit_string.hpp for external use
scope hei_includes.hpp for internal use
Add register dump to isolation data
Suppress chip data XML validation output
(From meta-openpower rev: c699cb1951899e19c994795e39dbff387e4c1c12)
Change-Id: I99100aef3a096f2687256dbf64dc6fb8533a60a2
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (2):
Attn: Change mpipl target to crash@0 target
Attn: Code cleanup based on CI build suggestions
Zane Shelley (1):
Clean up warnings from Jenkins CI
(From meta-openpower rev: 355e3846e90103502bd4c9fd6e48070ebdf0ae7c)
Change-Id: I524bac846c343520e9eb529b5b70e638bf8a4084
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
For phal based systems, move the memory preserving reboot function to
the obmc-host-crash target. This target is currently un-used on phal
based systems.
Make this move so that the obmc-host-diagnostic target can be utilized
as a more generic target. Dumps like hostboot, sbe, and hardware can now
utilize the obmc-host-diagnostic target to ensure the user knows when
any type of diagnostic event is occurring in the system.
Note that the obmc-host-diagnostic target will still be started as a
part of obmc-host-crash since that target is what communicates to
outside users that a diagnostic action is occurring.
To ensure we do not regress the dump functionality on our non-pHAL
systems, ensure the obmc-host-quiesce target remains within the
obmc-host-crash target. Our non pHAL systems go straight to quiesce on a
crash target call.
Tested:
- Verified with all commits in this Topic that the witherspoon system
has the same service layout as before and the rainier system
has the new layout (crash used for mpipl)
(From meta-openpower rev: b3f8d51109a607c6efc158198767395c6441b152)
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ia6d5411f84ec6c83a7edb177a1635c931bbda041
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Proper handling for unused parameters
(From meta-openpower rev: ab507b057bbf0454a9a81c064a2aa26e774ff1db)
Change-Id: Idb06d85b4160344b74b0f32131c7af51dd01a1df
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (1):
add timeout to stop-instructions service
(From meta-openpower rev: 0115043ef25fe58b57563f8c1a173590df8f13ae)
Change-Id: I0649c22ff825bda3402a3c1ddefc41e1e01a7656
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
For the synchronization targets to work correctly, a service must Wants
and After it. The Wants was missing here so there is a race condition
where this may run before the FSI scan service has completed.
(From meta-openpower rev: d1b13abc9dfaca474102bc09939efa417c5eeb3e)
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If02755f774c40a031ef2f37a3bc1718328da5a1d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (1):
Attn: Add support for raw PEL creation
(From meta-openpower rev: 075dcceaf5ecbf19f58902236a330d752b3fc13b)
Change-Id: Id8c520bf06cd1f3f7373017f6d2be844653f9083
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Proper handling for unused parameter
(From meta-openpower rev: 7c0d47e925427bab1caa7360118561f7d377358b)
Change-Id: I6ca8d027e74cba020e8ab3e990c33a55a00ce028
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
SunnySrivastava1984 (1):
Restore system VPD if EEPROM data is blank.
(From meta-openpower rev: adacb3a935e1a0b8136a832345557a9b4b6a4e77)
Change-Id: Iecd082f70e00fe00e388d1471d872d6d80b88d24
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Please see https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/39379
for details about why this is necessary.
(From meta-openpower rev: f528a4e54b1def5a482d4f8f0635d56c8bd1fe1e)
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I7c9104b3fab9acb1e9e12076e8a9bc4a85498270
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Alpana Kumari (1):
Enable pre and post actions
(From meta-openpower rev: a15cf55ee8affa1df02d009a07a8a6fca29a164d)
Change-Id: Iea29d4f5beb2c3fc2b8060ca98870e15f64ac70c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Update P10 chip data XML
(From meta-openpower rev: 7049665931cf13886c896f50707bc603bb7b2b03)
Change-Id: I085cb973a823fb9b9da862d9c6e8ce8cec45c752
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Restructure signature filter in analyzer
(From meta-openpower rev: d2a96131f61e524a79b459ce1ccc3856d3f87eda)
Change-Id: Ib768a90d66b7347e5b4e6a060df1b094e620b8dd
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (1):
Attn: Remove call to thread_stop_all
(From meta-openpower rev: 40f48e8e4fd552ea7ede9c8a2d730c1b835b0862)
Change-Id: I22499f62ff2ab8553ca77765f56140ee51476cfa
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
libpdbg:
- Added support for P10 chip
- Implemented new chip-ops for P10
libpdbg fixes:
- register access in sbefifo driver
- thread status in sbefifo driver
pdbg fixes:
- drop special spr access commands
- getspr/setspr uses spr names
(From meta-openpower rev: 8f73ef738b986950eb268c129f48a6eb805feee0)
Change-Id: Id264a39de1fcefa4b1df837d27075e8a8982f60a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (1):
config: add new everest machine support
(From meta-openpower rev: 3e7bd76e5bb64422a86e5c104585c1f92a94dc7b)
Change-Id: I73e084fe5f93a31f5ab683387d5933b69e288f54
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (1):
updater: Add missing static keyword
(From meta-openpower rev: be6d86035df507d01e8ea887225192d2d2ea6eb3)
Change-Id: Iff581fe5f157a5c477ff2bd70ac81ae2f26b7bf3
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Jayanth Othayoth (1):
Execute proc-pre-poweroff after proc stop instruction
(From meta-openpower rev: f85e69b2b87894c4b3666c281dc38242e5c37a30)
Change-Id: I009587fad12567b2acc3bd10809dba664f846540
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
When the obmc-host-quiesce@.target was initially created the idea was to
leave the system in the state it was in. In most cases the host had
crashed.
As OpenBMC has grown, the use cases for the quiesce target have grown.
For example the Quiesce On Hardware Error design:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md
When the QuiesceOnHwError setting is enabled, the host will be put in a
Quiesce state to indicate that an error has occurred. In a lot of cases
though the host actually can (and does) continue to boot. This causes a
lot of confusion for the user (host state shows Quiesce but host is
still booting).
This commit adds the op-stop-instructions.service to the quiesce target
to ensure the host is actually stopped when quiesce is entered.
Tested:
- Disabled AutoReboot and turned on QuiesceOnHwError. Verified when an
error which triggers QuiesceOnHwError was injected, the host state went
to Quiesce and the host was stopped via the stop instructions.
(From meta-openpower rev: ff3e548479bdf4c9db4315f45f1599a4f9adc33f)
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: If5cbdd03fbb3abcad8942e5ebe4e7b347ecfd599
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Changes:
-Adding support for new service
i.e. proc-pre-poweroff@.service, which will be called
during poweroff.
(From meta-openpower rev: 064663fa543eb32bf55f0657a56a3a6cf47bfe0e)
Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: I066bb91237f838c87de3da8e10b4d5a4fe7636e8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
srcrev bump 847f54c033..671a7da76e
Brad Bishop (1):
build: add dbus policy
Add dbus dependency.
(From meta-openpower rev: 01b774b773a0445b99e9ed15dea25cefd3ad39f5)
Change-Id: Ia011835542a9f03eb180609e2655576ab7453f86
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (1):
log entry to journal when rebooting bmc
Santosh Puranik (2):
Fix u-boot env var name for Rainier 2U
ibm-read-vpd: Enable skipping VPD read if host is powered ON
(From meta-openpower rev: 6a072515a03bf27b9f248aea0fd298aa15a3c3bd)
Change-Id: Iab72f477c2179dcbe5a7ebc33288325b61e45ba0
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Add all signatures to PEL FFDC
(From meta-openpower rev: 9206ed76239974613064c535919df3c1f3c77923)
Change-Id: I4e34224a0727a03f94db7ed7941f49b6cd42f886
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Deepak Kodihalli (1):
MAINTAINERS: Remove Deepak from the list
(From meta-openpower rev: 65fa7cbfea9df259ac55e106030024fb02e6c695)
Change-Id: Ibc678f997642eb9d3cce6bf2a7f9c7d75e49acdf
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (1):
Attn: Quiesce host on SBE vital
Zane Shelley (2):
fix query for hardware analysis enabled
Get chip ID/EC from hardware if not synced in attributes
(From meta-openpower rev: fde2db78ded4e793fcf567c5defe153676df2b3d)
Change-Id: I59c83f09bb3bb95175bbb00f5be381b09b43f856
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (4):
main: use sdeventplus
main: refactor service initialization
updater: add process-host-firmware subcommand
mmc: process host firmware blob files
Add cli11 dependency.
(From meta-openpower rev: 95932b73427f9b707ef5f12a522b8f9211fcf7dd)
Change-Id: I81d8a6aa1e6c1c7362d5203e25fe99e3031617b8
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (1):
cfam-reset: run before chassis power
(From meta-openpower rev: 498a5310b46a5602dd411aa5975872fe861549a4)
Change-Id: Ib5c60bbbb55045f63c13246caa2e7c212dea4095
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (4):
Attn: Additional tracing for attention handler
Attn: Probe pib target to detect enabled procs
Atn: Add sanity check for invalid fsi reads
Attn: Add TI info command field to valid check
Zane Shelley (5):
Fix exception util::transformFFDC()
Create util static library
clean up libraries in meson.build files
Clean up meson.build for reabability
Avoid analyzing hardware on legacy processors
(From meta-openpower rev: 1c77650c0e1e7fc83ea33a772b6423d69c5c73d1)
Change-Id: I5f0ff7c4886b894fec804462cf9793e703099c91
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Because meson is the de-facto build system for OpenBMC.
Fix a typo that results in mtd-utils-ubifs being added as an extra
build time dependency rather than a runtime dependency.
(From meta-openpower rev: 6122e25bb867d10bd2e7e92ddb36bed5b691b548)
Change-Id: I0d1bfc0912484fd86eb6523dcc0bebd18417fe65
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Expanded PEL support for analyzer logs
(From meta-openpower rev: 8abf0d5ddc0d01cd6cfd14e8c6cbdcee50407949)
Change-Id: I9bb9acfc25ea0c90e567a432f25141173e3b6068
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
SunnySrivastava1984 (2):
Custom Exception type for openpower-vpd-parser.
PEL creation in case of HW/SW failure.
(From meta-openpower rev: fab6ea8dd3595152f8e1cd017657845ec412a9ac)
Change-Id: I36a178d3ca612b892ce8e37a1b9e405a13280f54
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (1):
Attn: Revert back to local FFDC tuple function
Zane Shelley (5):
Proper support for initializing the isolator
util::pdbg functions for path, position, and target type
pdbg utils for finding all active chips
utility to transform an FFDCFile list for PEL consumption
pdbg util to get FSI target
(From meta-openpower rev: a07a6a971746c1d47b36a07ee13ba8bb27bf87aa)
Change-Id: I5fcef6116afce94bb5a03d0ce238345968f87a74
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ramesh Iyyar (1):
phal: Corrected condition to add trace for FFDC
(From meta-openpower rev: fda904e173ae6b9c82b2df922520b77c50875985)
Change-Id: I33314dd88832a35d902a7280da3db60d1022e3d6
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (2):
Update XML for new Explorer levels
Signature::toUnit32() helper for logging and tracing
(From meta-openpower rev: c08ba352770820f721e27f5e158ec211746b535f)
Change-Id: Id4117a6633eb7ba86ed099b07f5f489eb0c59150
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Priyanga Ramasamy (1):
Fix some warnings
(From meta-openpower rev: 8290a9df225d1fde2f470f5d3919fa898e59e51d)
Change-Id: I20027c0f8296e874f233faab7edc61421cc06770
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (2):
spi-mux: ensure mux is reconfigured on chassis off
spi-mux: do not set if chassis power is on
(From meta-openpower rev: aaf0401c8773a4c7693ad395fcc703938a916760)
Change-Id: I6783225dba2e7ca56c80ad3adea282aa3b61e99b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (1):
meson: fix busname
(From meta-openpower rev: 29f6d7151310ea2b01b73a868070af5545ca8646)
Change-Id: I3fc577dc9a392a2d03d3477ca7b47988abfcc9e7
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (1):
Attn: Cleanup trace messages
(From meta-openpower rev: e9a558866d4471f6781b69f5af51dc53fb539b53)
Change-Id: I7b5166fe97589053ad80ee0c7b3d4ec7f97b7562
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
Build Chip Data binary files from XML
(From meta-openpower rev: 64ce5cab440ddde777d130132146a54433d1715e)
Change-Id: Ic9de8b9f9c89f19b43f779d997654b6019ca1327
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (1):
build: update clang-format
(From meta-openpower rev: d6bc07ce396e2c69ebd47aa35cf5cdf3d0d860be)
Change-Id: Ida7e53b6ffb59d767c7ad88fa8b1fb4f71581f0d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (5):
style: update clang-format
c++17: drop experimental::filesystem
fix compiler warnings
build: add support for meson
systemd: avoid {BUSNAME}
(From meta-openpower rev: b0bdcc2c94a1a0facfc6ada1b07901e8b8ab5a27)
Change-Id: I476e40c631fe31a865c5eb98f703567df8f8ad1d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Brad Bishop (4):
test: remove gtest subproject fallback
meson: install executables
meson: fix systemd service bugs
meson: add checks, defaults
Gunnar Mills (1):
test: Makefile.am: Remove -lstdc++fs
(From meta-openpower rev: 275f79f6025d6d870286a0d0c2b1e1e17a14e015)
Change-Id: Ia1ffbdb2d0d0e7fec44892d931838f32be210c29
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ben Tyner (3):
Attn: Seperate handling of PHYP and Hostboot TI
Attn: Add FFDC logs to PEL
Attn: Code cleanup based on local CI build output
(From meta-openpower rev: b5be9aedbea87b36603385cb4b26d8246c56eddf)
Change-Id: I23cb3c5ec56871e0ae15d8bfd6afce289ee1e7c4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
(From meta-openpower rev: 0d19816dff224f6e760e19e27749493907b2b4d0)
Change-Id: I50d4ac220d253fe9055ef62621721b69cfde432b
Signed-off-by: Zane Shelley <zshelle@us.ibm.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (2):
Externalize chip data file keyword constant
Copied Chip Data XML from Hostboot project
(From meta-openpower rev: 590bcd28384341c96d6fb5599c8a7418c024648c)
Change-Id: Iab28c2bc2954d2b16b65e4ba7dcb1e75892447bb
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Santosh Puranik (1):
ibm-read-vpd: Switch to the right symlinked JSON
(From meta-openpower rev: 38bde767d3d102dfa78aadd2fa69886dfe97240e)
Change-Id: I175cf33b5cd54df2466c0c6bb68cb8ba653ea573
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
The next release of Yocto is soon and most of the upstream
layers have switched support strings for it. Support layer
compat for gatesgarth (current) and dunsfell (previous).
(From meta-openpower rev: d6809d5e21b57fca14572a4a1a945f3caa1ef91b)
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I168a928a18d8b5c6146cc615f7070bb98a06bceb
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Zane Shelley (1):
meson library and dependency cleanup
(From meta-openpower rev: de04607b89c0dccb74ff4ecdcc6b1ad992945c66)
Change-Id: I9ff59d362775cf3923663cdee473fb00754a32bc
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Andrew Geissler (1):
host-stop: ensure stop-instructions run in correct seq
Brad Bishop (4):
phal: use unix line breaks
c++17: drop experimental::filesystem
fix compiler warnings
build: add support for meson
(From meta-openpower rev: ba05405cf35a4556b23f5269aca1c10740d43a9b)
Change-Id: I513c86ee5377eab6eb74c598f5df3c3d9e4c0bcd
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Alpana Kumari (6):
IBM Read VPD support for processor vpd
Memory VPD parser
Handling FRU and Module in vpd read code
Handle CPU Module and FRU in write VPD
Support FRU Type in vpd tool
support multiple device trees in the same BMC image
PriyangaRamasamy (2):
Prime the Inventory VPD objects
IBM VPD Parser support for both 2U & 4U system
SunnySrivastava1984 (2):
Code refactoring
Interface & Factory implementation for VPD Parsers
(From meta-openpower rev: 9eee15c9aca0daa4267e53fc9001cf0263d93bda)
Change-Id: I8eefac11437753dea4650eb99740fb645c5a0174
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|