Age | Commit message (Collapse) | Author | Files | Lines |
|
It was reported that after 5a5f33c729e6b5869362172b63595422eb84a418 the
qemu images are not buildable. Treat qemu systems like an 'evb' so that
the obmc-system-mgmt package is not included. Make a minor change to
how evb is specified so that it is treated as a MACHINEOVERRIDE that can
be leveraged in multiple recipes.
Tested by ensuring that `evb-ast2600` still successfully resolves all
package dependencies (with `bitbake -p`).
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iff4573aa3d4aac30a6681ed75741a6e351bda982
|
|
Add the BUILD_ID value to the MANIFEST so that it can be used alongside
the VERSION value to generate a version id during firmware updates.
Add a function to read BUILD_ID from the os-release file instead of
reading it from a variable because the BUILD_ID value could be set via a
os_release.bbappend file instead of a .conf file.
Tested: Verified the BUILD_ID value was added to the MANIFEST by
default, and when BUILD_ID was specified in a .conf file, and on a
os-release.bbappend. Ex:
$ cat MANIFEST
purpose=xyz.openbmc_project.Software.Version.VersionPurpose.BMC
version=2.11.0-dev-566-g263df7f852
BuildId=20211025151654
ExtendedVersion=
KeyType=OpenBMC
HashType=RSA-SHA256
MachineName=p10bmc
Change-Id: I3b7beaccbbd47d8820d499180ccdf021b004cf85
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
The obmc-system-mgmt feature is currently used in the image to trigger
inclusion of a virtual-provider which provides a number of packages many
systems need. Partially revert the removal of this feature so that
the outcome is:
1. The empty obmc-phosphor-sysd package is still removed.
2. By default the 'obmc-system-mgmt' feature is included, unless
specifically exempted.
3. All EVB platforms remove the 'obmc-system-mgmt' feature since
they have no system they are managing.
This partially reverts commit 060ad3ff7fcc30aff78a9e504efee9d8fa0d4526.
Tested:
* Built `bletchley` and confirmed `packagegroup-fb-apps-system` and
`entity-manager` are present.
```
entity-manager armv7ahf-vfpv4d16 0.1+git0+6bf41588ab-r0
packagegroup-fb-apps-system all 1.0-r1
```
* Built `witherspoon` and confirmed `packagegroup-op-apps-system` and
`pdbg` are present.
```
packagegroup-op-apps-system noarch 1.0
pdbg arm1176jzs 3.3
```
* Ran `bitbake -p` on `evb-ast2600` to confirm the undefined
`virtual-obmc-system-mgmt` is not being included in the image.
Change-Id: I8b7804d5101cc84a2c57473b3f85672bf7767c67
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
Manojkiran Eda (1):
Add OWNERS file
Change-Id: I7baeec6ca85478efeee3ee8ef80536527abc6890
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Every machine layer treats 'system-management' as either part of a
package-group or removes the feature. The sample implementation in
meta-phosphor is a do-nothing shell script (and up until recently was a
Python script). There appears to be no useful purpose to this feature
as a stand-alone concept, so remove it.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I20ca1fa8ff3cb01cac2d07d4ded84e0769e4514b
|
|
The logic was broken due to lack of quotes around the semicolon
delimiters inside subshell commands. It did not work for single keys nor
multiple keys provided in SSH_KEYS.
This commit adds proper quotes, and also refactors the loop a bit to
reduce repeated commands, reduce indentation, and clarify variables.
Tested:
- Added INHERIT/SSH_KEYS to local.conf as described in script comments.
- Tested with 1 key: "root:/path/to/key.pub" and 2 keys
"root:/path/to/key.pub;root:/path/to/key2.pub".
- Verified that in all cases keys were added to authorized_keys files
exactly once by checking rootfs output:
(build/tmp/work/<machine>/<image>/<version>/rootfs/home/root/.ssh/authorized_keys)
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: I58af4e8107daa6447b8276a66fc7c91e346c7dd5
|
|
As a follow up to 400d9dab03e25d992429f94296caa4938c281fbd, fix the
deprecated SafeConfigParser to ConfigParser across the tree.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iabf941889eed97a996b739d77c8107f1f35ce5bf
|
|
There is a warning message in the obmc-phosphor-systemd.bbclass file
when using bitbake to build image-bmc:
```
DeprecationWarning: The SafeConfigParser class has been renamed to
ConfigParser in Python 3.2. This alias will be removed in future
versions. Use ConfigParser directly instead.
parser = configparser.SafeConfigParser(strict=False)
```
Use the class name `ConfigParser` directly in the configparser module.
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I6168d9d1100ac846cc31be837a20b7dedb6d7910
|
|
Move static dbus config directory to be `/usr/share` instead of `/etc`,
which is recommended by `dbus-daemon`.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ifd210a262e1c8025dc9e3037c9970ec66ebb085b
|
|
In the spirit of consistency with the new upstream override
syntax, change phosphor-discovery-service.bbclass to use it
and make tree-wide changes as appropriate.
After the change checked on Witherspoon on QEMU:
```
root@witherspoon:/etc/avahi/services# ls
obmc_console.service obmc_redfish.service obmc_rest.service
```
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib1fe3cce57a0130378af789abd83b457e0c3a318
|
|
Upstream bbclasses changed to typically use the `:${PN}` override
syntax, including the SYSTEMD_ variables. Change our systemd.bbclass
to do the same for consistency and perform a tree-wide variable
replacement.
Spot checked by building bletchley and witherspoon and checking
some of the SYSTEMD_LINK directives on installed packages under qemu.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I20a9dd809bff8af8759488734f80486c7228c6eb
|
|
It was observed that we have different approaches to modifying the
EXTRA_OEMESON variable across our recipes. The bitbake manual
implies that override syntax (":append") is slightly better and the
poky meson bbclass also prefers it:
meta/classes/meson.bbclass:EXTRA_OEMESON:append = " ${PACKAGECONFIG_CONFARGS}"
Switch all recipes to use the ":append" override syntax for the
EXTRA_OEMESON variable.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I24e9a27a87c61f374acfb03a63955821fce0dd20
|
|
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I588025b614416c43aa2d053765ab53bacf890cb5
|
|
Add an addition override for 64MiB static flash layout.
The existing 32MiB layout are unchanged:
partition: size: offset
u-boot: 384 KiB (0 KiB)
u-boot-env: 128 KiB (384 KiB)
kernel/FIT: 4352 KiB (512 KiB)
rootfs: 23808 KiB (4864 KiB)
rwfs: 4MiB (28672 KiB)
The existing 128MiB layout are unchanged:
partition: size: offset
u-boot: 896 KiB (0 KiB)
u-boot-env: 128 KiB (896 KiB)
kernel/FIT: 9 MiB (1 MiB)
rootfs: 86 MiB (10 MiB)
rwfs: 32MiB (96 MiB)
The new layout for 64MiB is as follows:
partition: size: offset
u-boot: 896 KiB (0 KiB)
u-boot-env: 128 KiB (896 KiB)
kernel/FIT: 9 MiB (1 MiB)
rootfs: 32 MiB (10 MiB)
rwfs: 22 MiB (42 MiB)
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Change-Id: I001cf2e9bc30edc34e43c0c4503684050e2a764f
|
|
- We will hit a problem intermittently when we build image-bmc:
We have 2 tasks running in parallel, the `do_generate_static` and
`do_generate_static_alltar`. Both specify to use the same work
directory, and both call to generate the signature files:
do_generate_static_tar[dirs] = " ${S}/static"
do_generate_static_alltar[dirs] = "${S}/static"
Depending on timing, one task can remove the `image-full` file from
the directory and the other task won't find it, and cause built
failed.
Error message: image-full: No such file or directory.
- Resolves openbmc/openbmc#3797
Tested: built obmc-phopshor-image successfully.
Temporarily solve openbmc/issues/3797
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I7147f6c8db4f3a2a0c0c9bd54ac384ee8882b233
|
|
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I638e0ead44f6de23f5232bffb1067cf309412129
|
|
Bruce Mitchell (1):
Replace IRC with Discord
Lei YU (1):
Fix the same static IP setting from DHCP
Patrick Williams (1):
use new sdbus++ camelcase
William A. Kennington III (1):
ethernet_interface: Fix variable naming
Change-Id: Ib7d883dc97c18dfcd906b2613b5312966cc0d142
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
use new sdbus++ camelcase
Change-Id: I436d7afb03b58974ea4dc33a01eea1169ab1033c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
William A. Kennington III (1):
util: Remove temporary strings in getIgnoredInterfaces
Change-Id: I5519523d24bbb75868252e25c1b022e8d3144c9f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Lei YU (3):
Re-organize internal namespace
Get ignored interfaces from environment
Ignore the interfaces defined in IGNORED_INTERFACES
Change-Id: I61343d73f65bdd89eafc5d187a9a0d03a160e98a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
phosphor-logging use to need to run in a native context to
provide YAML processing but that is no longer necessary since
commit e523a091d0977adf639eaa7cdf4f895614d2696c. The support
to install just the python scripts in a native context overly
complicates both the recipe and the corresponding repository
build scripting. Remove it since it is no longer needed.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I67542f8f63bf9e30166ac1ab46eb85074cf3e843
|
|
William A. Kennington III (1):
util: Collapse toCidr functions
Change-Id: I9190fd2d70643c8b4f390fac10fe9d3a6175e29c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Manojkiran Eda (1):
Fix shell check errors & enforce it in CI
Change-Id: I60bb7a6ed2c86f17bb35360b012ff791d33ed82d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
John Wang (1):
Change the IPV6_MAX_PREFIX_LENGTH to 128
Change-Id: I89f14ba000b6d6263dae5fea83966741bee7dc42
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
DynamicUsers flag in systemd service configuration file required to create,
handle and recycle temporary users.
This is essential module for upcoming daemons' privilege separation work.
Reference: https://github.com/openbmc/openbmc/issues/3383
Signed-off-by: Anton D. Kachalov <gmouse@google.com>
Change-Id: Iabd709c4a20f754fc6ea505e640b2d361aba0be2
|
|
Lei YU (1):
Fix __builtin_ctz related bug
Change-Id: Ibfc97185d282d738de6fdc74732813e73982b2c9
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
The commit meta-openembedded: subtree update:98175fd0cc..da393545a2
removed the zstd recipe (zstd_1.4.5.bb) from meta-openembedded and just
left the one in oe-core (zstd_1.4.9.bb):
Randy MacLeod (6):
zstd: remove the recipe since it moved to oe-core
The 1.4.5 recipe had a change to split the binaries by adding "inherit
lib_package" to the recipe, but this change is not present in 1.4.9.
We'll need to check for any zstd changes in future poky updates since the
person that made the change to split the binaries in meta-openembedded
might make a submission to port that change into the oe-core recipe.
Even though this change will compile, it would break firmware updates on
Rainier because only the zstd libraries would be installed and not the
binaries. Therefore this commit must be submitted at the same time as the
meta-openembedded subtree update.
Change-Id: Ie7246195f5db42a1a0c402643439d312ad058a80
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
Johnathan Mantey (1):
Improved IPv6 netmask parsing
Change-Id: Ib1f8fc86e57be7a873ea438f2e7824b70fde0e72
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Alexander Filippov (1):
Fix representation IPv6 DNS servers
Change-Id: Id5bc44e0581e181f4e525c33d48dfe72b0d2f687
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Johnathan Mantey (1):
Removing inactive reviewer
Change-Id: I887b351493cdb53256787f33a7742f41aacf9f21
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
With openbmc commit 97771a3:
"meta-openembedded: subtree update:7206f7f5bc..98175fd0cc", the zstd
package was split into libraries and binary:
Sean Nyekjaer (3):
zstd: split bin into separate package
This change added an "inherit lib_package" to the zstd recipe which
creates a separate ${PN}-bin package.
Therefore, need to use zstd-bin to include the binary. No need to keep
zstd since the libraries are not needed for code update to extract the
image files.
Tested: Verified the zstd binary existed in the rootfs and code update
was successful in Rainier.
Change-Id: I379ec2b0d85090df5183e3581bc88384eaf4dbc6
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
Ravi Teja (1):
Fix [route] statement
Change-Id: Idd62262e90f8651e857e59ed0318c3787b302f7f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ravi Teja (1):
Network: Implement ipv6/ipv4 default gateways on EthernetInterface
Change-Id: I4a4c3f80b11c1f3787749b4729455f32459be091
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
When running with Python 3.8 these statements will warn with:
SyntaxWarning: "is" with a literal. Did you mean "=="?
Change-Id: I44a873bce37d189d09bd73e64890cc821205cbbf
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
This patch will add the "ExtendedVersion" field in manifest file.
Note the extended version is typically set in the
openbmc/meta-*/meta-MACHINE/conf/local.conf.sample file
(This is where TEMPLATECONF points to.) by "EXTENDED_VERSION"
variable.
Signed-off-by: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
Change-Id: I071448badd3b3f56e7d771af0a058bb58db04511
|
|
Manojkiran Eda (1):
Make the Individual tests linkable for meson
Change-Id: Ia7fd8649fa0ccfbb660febae8a93f5b73c99a67f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Added telemetry package to obmc package groups. Added telemetry
to image features for easy opt-out.
Change-Id: I66be3a545a1ce1cfb2c2c241629168c5b8d56c0d
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
|
|
Ed Tanous (1):
Fix build time error
Change-Id: I16b21fd62fc18c2753ef80518dc3ae63f16a5839
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
The phosphor-deploy-ssh-keys.bbclass was intended to be an optional
method to add additional SSH keys into a test image, but the way it
was implemented the class is always creating warnings like:
WARNING: obmc-phosphor-image-1.0-r0 do_image: Trying to deploy SSH keys
but input variable is empty (SSH_KEYS)
Remove the inherit in the phosphor-image. If a user wants this feature
they can edit their `conf/local.conf` to add:
INHERIT += "phosphor-deploy-ssh-keys"
They are likely doing something similar anyhow with the SSH_KEYS
variable (adding it to the conf/local.conf).
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id06e25ba0d22f021d81ee2cd0110d696591c1f59
|
|
Asmitha Karunanithi (1):
Fix core dump when invalid MAC is configured
(From meta-phosphor rev: c609625ff765c6f9456c96926e21567b95b7c10c)
Change-Id: I399884aa659541b4bc3d885ab59fb08488faba31
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Ed Tanous (1):
Fix -Wformat-security issue
(From meta-phosphor rev: c24245f8491c45eeaf4e4df07369031e061c1b4f)
Change-Id: I455c14cb65fa571eb917b0306ec16949f7797534
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Currently the contents of the code update tarball are individually
signed and signature files for each file are created.
In order to ensure that the contents of the tarball are the expected
ones as a full package, it is necessary to create an additional single
signature file bashed on the individual signature files.
(From meta-phosphor rev: 80b9baede615563bc15e5218cb051f57ae451b8d)
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I6373d4f0387e8f64c2c30be05e0d43af4ed9b913
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
There was support to inject an empty "SYSTEMD_PAGER=" variable
into the profile. This was to workaround ANSI control characters
being injected into the default systemd tool output, but has a
side-effect of disabling the pager for useful commands like
`journalctl`.
The underlying cause of these control characters was that busybox less
was missing features that systemd relies on. Many of these busybox
features say "this is essential for less applet to work with ...
systemd": https://git.busybox.net/busybox/tree/miscutils/less.c#n103
These are now enabled so this empty environment variable can be removed.
(From meta-phosphor rev: d8f8d70f7e4771eb295fff3ca80182b6636411b6)
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idc2fef9ccfb28e7956caf4efc141698940879f65
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
There are errors seeing in the eMMC when the empty space of an
image is filled with 0xff like it's done for NOR chips instead of
0s. Create a function to create empty images with 0s.
Also create an empty image for u-boot of 1MB (twice its current
size) so if the u-boot image that is flashed on a system is
smaller than what the system has, there's no leftover data at
the end that can cause issues.
Tested: Booted the new image-u-boot file on HW.
(From meta-phosphor rev: e4c3d766a0cda490758636f563572152a6ddfaa1)
Change-Id: I27f31f76c38bc256b84cad566afa1e98471695db
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
A number of tasks that depend on deployed images erroneously depend on
do_populate_sysroot instead of do_deploy.
This can have a range of side-effects such as failed image tasks because
of missing or stale sub-images in DEPLOY_DIR_IMAGE.
(From meta-phosphor rev: 1595ecbe6726f66bd40fcdde02f946a784bf7376)
Change-Id: I1d20c1a65f10ed38517b5ba5e87946c64b574eaa
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
(From meta-phosphor rev: 75c8dc6f5fc565a92da9129291ea09319e8593a6)
Change-Id: I375e188abbf3115e00d3ace1ad201d9fc11214d9
Signed-off-by: Jean-Marie Verdun <jean-marie.verdun@hpe.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Fix the following warning in bitbake:
WARNING: python should use 4 spaces indentation, but found tabs in
obmc-phosphor-discovery-service.bbclass, line 76
(From meta-phosphor rev: 427731f6f772ea7172ad4dc5328fa11ab51c3b17)
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I23ecd244376ecc2dff2bc7bea6902a567404196a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Currently, we'll export avahi services solely under their service names.
With multiple BMCs on a network, this ends up with multiple
indistinguisable services exposed over avahi:
[jk@pecola ~]$ avahi-browse _obmc_console._tcp
+ br0 IPv6 obmc_console _obmc_console._tcp local
+ br0 IPv4 obmc_console _obmc_console._tcp local
+ br0 IPv4 obmc_console #2 _obmc_console._tcp local
+ br0 IPv6 obmc_console #2 _obmc_console._tcp local
This change uses the hostname as the identifier instead. There's no need
to include the service name, as that's what the service type field is
for.
(From meta-phosphor rev: d4e212eeed5832685839e24cf9ec4207ea3f32ae)
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Change-Id: I6b18b60c28cf4f2699693d41c2d52d56cd87a26a
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Add a fru-device package, packagegroup, and image feature.
Remove the ipmi-fru distro feature, since adding it in the first place
was a mistake - no projects have conditional ipmi-fru feature flags.
(From meta-phosphor rev: 4525a9d01a5f65438342a894f27c82f0dd61642c)
Change-Id: I6928ac67d4acb4568359a308b45cb0734d116054
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Add phosphor-health-monitor packages to obmc packagroups and create
IMAGE_FEATURES for easy opt-out.
(From meta-phosphor rev: 67a3c577eced35685ec373b30a1419be5f3d3827)
Change-Id: I912610933a2e73530e862feff684134dce9dfe99
Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|