Age | Commit message (Collapse) | Author | Files | Lines |
|
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I588025b614416c43aa2d053765ab53bacf890cb5
|
|
The feature was implemented as an append to the kernel (BSP) layers in
meta-phsophor. This created a three way dance between machine layers,
BSP and meta-phosphor, when it should have been the kernel layer
providing this feature and machines could then opt in.
Fixing this means we could remove the KERNEL_DANGLING_FEATURES_WARN_ONLY
workaround.
As the feature is simply turning on a pair of kernel options without any
other impact, we can implement it by adding the options to our
defconfigs. In fact, aspeed and hpe kernel configurations enable the two
kernel options:
$ git grep CONFIG_KEYBOARD_GPIO=y
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g4/defconfig:CONFIG_KEYBOARD_GPIO=y
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g5/defconfig:CONFIG_KEYBOARD_GPIO=y
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g6/defconfig:CONFIG_KEYBOARD_GPIO=y
meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/defconfig:CONFIG_KEYBOARD_GPIO=y
$ git grep CONFIG_INPUT_EVDEV
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g4/defconfig:CONFIG_INPUT_EVDEV=y
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g5/defconfig:CONFIG_INPUT_EVDEV=y
meta-aspeed/recipes-kernel/linux/linux-aspeed/aspeed-g6/defconfig:CONFIG_INPUT_EVDEV=y
meta-hpe/meta-gxp/recipes-kernel/linux/linux-obmc/defconfig:CONFIG_INPUT_EVDEV=y
Other machines that wish to enable this feature should ensure it is
added to their BSP's defconfig, or add it to their machine specific
defconfig.
Change-Id: I0726836319022f96c1d13d4a0cbd73708047302c
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
Setting this within python is not required
(From meta-phosphor rev: b737ffb23aff232b2ce212ad54171afe7b216a71)
Change-Id: I3d799b5cd9e66c9bc1a4d145274bfa3c06bdf575
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Uptream yocto recently added some new code which enforces
kernel feature validation. The commit which did this is:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=095175595d9f28d5a0eb7ea520c9af0100bb8dfd
This caused OpenBMC builds to start failing with the following:
| ERROR: Feature 'phosphor-gpio-keys' not found, this will cause configuration failures.
| ERROR: Check the SRC_URI for meta-data repositories or directories that may be missing
| ERROR: Set KERNEL_DANGLING_FEATURES_WARN_ONLY to ignore this issue
OpenBMC does not utilize this aspect of the kernel-yocto.bbclass
so make it a warning only.
Tested:
Verified that the resultant build still had the expected CONFIG
options set in the linux-nuvoton .config file
See openbmc/openbmc#3690
(From meta-phosphor rev: 75a6424eec93729fd40154413b1a350b9f10fe8b)
Change-Id: I12bf3857601f186300d3b1c56c490be6e6582dda
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
The phosphor-base.inc distro file enables the phosphor-gpio-keys
KERNEL_FEATURE. Add support for this feature to the linux-nuvoton recipe
via a bbappend in meta-phosphor's nuvoton layer.
Tested: Built and ran on NPCM750 EVB
Change-Id: Id957c6209ebb841fce2cdad1cc0790e0d58da60c
Signed-off-by: Benjamin Fair <benjaminfair@google.com>
|