Age | Commit message (Collapse) | Author | Files | Lines |
|
Not querying password for invalid user name is security
issue and can be used to determine valid / invalid user names
in the system. Always proceed to password acceptance screen
for invalid user login attempt too. This commit configures
pam_tally2 to ignore unknown user and proceed to do password
check.
Tested:
Verified the same in bmc serial console login with invalid user
name and password was requested, before displaying login incorrect.
Note: dropbear handles this already and hence ssh will not exhibit
this behavior.
(From meta-phosphor rev: 356ec08b989c84d1d034c3ff283a6909658d9435)
Change-Id: I72483d26ad7b7c39068ac33b7387adf2b10a1a27
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Default credit for pam-cracklib was used, causing issue
in meeting minlen requirement for new password. i.e. 1 credit
will be applied if the password containts, digits, upper case,
or lower case etc, making minlen to be accepted. "fw6ev9" will
pass pam_cracklib earlier for minlen as password length was 6, +2
credit got substitued for lower case & digits use in the password.
Correcting the same now, by not providing any credit, and so the
minlen of 8 chars in the password must be met.
Tested
1. Tested password 'fw6ev9' fails to set
2. Tested password '0penBmc1' was accepted as it passes 8 character
Note: With this commit, the current default passwd for root user
'0penBmc' will work fine, but the same can't be used as password
during password update.
(From meta-phosphor rev: 0e67cd66f4f530b4ccccb2ab400ba2dabb3c0737)
Change-Id: Ieeebef45a655563ac7779627b1cf38ef6080c046
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Richard Marian Thomaiyar (1):
Allow async_method_call to provide opt message
(From meta-phosphor rev: 738ab0df153b75cf7be7cd0f7e9920db1c6e6e5f)
Change-Id: I11435dc4405adff04b3606ab5345a9140e7d2527
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (4):
signal: Use callCheckErrno
handle: Make it possible to reference stored data
handle: Support for releasing management of values
util/str: Add string concatentation methods
(From meta-phosphor rev: 64de25902197895564789681368a260baf7225d7)
Change-Id: I5dbf739ed99a8ded6260c3f61a96c3ad3c33d0d6
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
autotools: Remove
(From meta-phosphor rev: 9f3ab4afad01a0e718f528728eaf27a6bac2f92b)
Change-Id: I4046348107f8ed11d6177d0f8ac840482d98d741
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
README: Expand documentation to include an overview of repo contents
(From meta-phosphor rev: d8dd8e466b8ac5901e7aa08bb660689cf65f12d9)
Change-Id: Ie2c90839fafd0bc7e230c70d1bfecf3bf74445d4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
clang-format: Apply update 6 -> 8 fixes
(From meta-phosphor rev: a02e08a6e243aa161982ad7d4a79530bef8a704d)
Change-Id: Ia3db362931479f3a74dfa65ac352ae0167cbf2d1
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Commit 138108a changed the way the rsyslog service is
started. It removed the rsyslog override config file
and also removed references to the rsyslog-policy recipe
that used to install that file.
However, rsyslog-policy recipe itself was still a part of the repo.
Bitbake would still parse the recipe and warn about the missing
rsyslog override file.
This commit removes the policy recipe from the repo.
Tested:
No more warning when we bitbake a phosphor image.
(From meta-phosphor rev: 03b8ecd41c69e2754830efc274961432d7a77358)
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I292e13f565c40b32527427154b5f570767146827
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Lei YU (1):
message: Add get_error()
William A. Kennington III (1):
native_types: Fix string_wrapper overloads
(From meta-phosphor rev: 7240a8a764e93452f76c15a5a1f28e68df6d1fb6)
Change-Id: I7324148e4bd686148178f01cbe6949dd8fbc3c93
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
James Feist (1):
asio: Allow mutable lambdas + small cleanup
(From meta-phosphor rev: dc517d8f0de04806775021926e982527e26762eb)
Change-Id: I81983da204f4fcc9728d05a1d0e3965ddbd70099
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
autotools: Remove
(From meta-phosphor rev: a8e6b965e2ab9e108e3f1e1be9f73fa8270e4adf)
Change-Id: I30c32d312aabc3ce2f8ff02280cb4cf2577ebbc2
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (3):
autotools: Remove
sdevent: Support getting userdata
sdevent: Support source destroy callbacks
(From meta-phosphor rev: d4572fb81b0642530a97024f0daab0dec164a13c)
Change-Id: Ib8b61d7b53cce788c50430a2916aef7470f4aa9e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
An upcoming change will require this dependency for sdeventplus, so that
we can store functions containing move-only types for callbacks.
(From meta-phosphor rev: c345eb3b55f168f17e7025eaeed5ad603af6745f)
Change-Id: I30b3caa38f26414b82493301bd7acd466f9814bc
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
This reverts commit 37bc1a3568f2e87987be05243627a984dc051de1.
In addition, it changes the default rsyslog server config to
ignore all messages. Also bumps up phosphor-logging:
phosphor-logging: srcrev bump f59854e94b..0a0b5ea558
Santosh Puranik (1):
rsyslod: Change disable action
Tested:
Verified that the default rsyslog behavior is to now ignore
all messages.
(From meta-phosphor rev: 138108a05f68ada8b990024bbaa8b68b135d6aeb)
Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Iba11dfa153eaeef17417c82ab26f9a26fe5f9125
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
sdbus++: Fix construction of objects with flags
(From meta-phosphor rev: 2e26c6f52808546f43d02cb57ac1026e7fe6c05a)
Change-Id: I6e9c191f5acb1e90711de70f8752361ebe45e84c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
We intend to remove autotools from the gpioplus build eventually. This
is the final step needed to use meson for the package.
(From meta-phosphor rev: c86057c5636542ad7fa86bbd2a31b9090a8c2a30)
Change-Id: Ided281441177e3f4f136d5a84ad3b139adb0000e
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
message: Fix passing of sd_bus interface to new messages
(From meta-phosphor rev: 084d5478f8727af2ec8f2a6583d6b3a5a3c200fa)
Change-Id: I4775f2addca7db6f46de3332d112a0f1b1638b36
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Vernon Mauery (1):
Change async_method_call to be no-throw
(From meta-phosphor rev: 49a5c2a9e6b22b255452610ed763098e8945ee88)
Change-Id: I274def9c2727989277e24f7d25530b60d9ea60c7
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Vernon Mauery (1):
MAINTAINERS file had the incorrect email address
(From meta-phosphor rev: db87a5a1bb81c00bc64cc15baf137c69d44bfdda)
Change-Id: I5f966a08ff21f62fc82879ca54e042cd457ebce4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Cleanup the extra oeconf variable in the recipe such that it's an
assignment and not an append and isn't a mixed-evaluation line.
(From meta-phosphor rev: 60c2de3f042aa6e179390ac883660e0b23c90de4)
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ia61ea129d2d6309df334915723d4caf8808762a0
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Vernon Mauery (1):
Change yield_method_call to be no-throw
(From meta-phosphor rev: 6ac8fcf74ead9a41b12202dd78f1277ad4996de2)
Change-Id: Iad4b371c517fc2942e40007ac2b07e46df444753
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Vernon Mauery (1):
Add vmauery to the sdbusplus maintainer list
(From meta-phosphor rev: 4adcda8f219840b5218b93028b64e814c9775010)
Change-Id: I044aadda7749383bf8f67f0f286ba8a09bf1b880
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
std::variant: Remove uses of the variant_ns
(From meta-phosphor rev: db66ead618460df8962c61255db1b2d7f8ed670b)
Change-Id: I23c253cd80b998b7e48050eedfedb0b687c27fef
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (3):
sdbus++: Fix mako include substitution for signals
sdbus++: Allow server.hpp files to have extra generated includes
sdbus++: Generate includes for enum references
(From meta-phosphor rev: bae4113f94c5f37da6d8068e0cae150cdf8e0e28)
Change-Id: I9eb28e5a62c07fd669e4d4770930f95d2e1211ab
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
This will allow us to get rid of autotools in the upstream sources.
(From meta-phosphor rev: 6838e7ce10ee9970aeb27262dcc45d11449f21d3)
Change-Id: I57490fd3635357bc203e8fb0e40b27217e5d8f79
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
This will allow us to get rid of autotools in the upstream sources.
(From meta-phosphor rev: fe1b9e8f48bece7e78be566de44d634a6c5a4b35)
Change-Id: I1f1703d742d227604c95f6d86ce5d8b44a3240bd
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
meson: Use declare_dependency for libraries
(From meta-phosphor rev: 3f9ff5ca207cb3fa8db7a7ce809f217935b45c95)
Change-Id: Ia2dbbfeb18967b4ec762343fc37a4d7e2c49e8e7
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (3):
source/base: Fix docs for owning constructor
meson: Style fix
meson: Use declare_dependency for libraries
(From meta-phosphor rev: cef82489918d057ba289ceea485ce2520fb9451e)
Change-Id: I9bee365cbf3702df84e90880c2f14de9602510f7
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (2):
meson: Style fix
meson: Use declare_dependency for libraries
(From meta-phosphor rev: 391aa60ad35daee86a7f62821ba7b1b5b2e90d2e)
Change-Id: I96e5410e32f05db22d88313ffd3719b703bf39bb
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
It is undesirable to have a service restart continually forever if it
gets stuck in a failure loop. This workaround was added due to
"RestartUnit" being ignored if the rsyslog unit had already failed. A
fix to the "RestartUnit" logic has been added, so that the StartLimit is
reset after a configuration change but before calling "RestartUnit".
This will ensure restarts are reliable after configuration change, but
we don't have rsyslog trying to restart indefinitely.
(From meta-phosphor rev: c82d32f8e6993f83ddda35dd1a2152eca8188408)
Change-Id: I719489ceadfadb3cca71bbdbb1697fa83cad2e2f
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
meson: Fix pc file generation
(From meta-phosphor rev: a58514c70aa2b4425f1aa653e7defa2db0ec2945)
Change-Id: I6b0e1689fbaea97b8142cbd7bdebea0aa2f83532
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (3):
example/heartbeat: Add signal handling
internal/utils: performCallback should preserve argument references
source/base: sourceCallback forward reference type information
(From meta-phosphor rev: 246989e3e15f6080aadcbb2f1b367c0cdcc89140)
Change-Id: Iebc2f95a48c2b58de99a4a69c2e873a382bd3598
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (5):
tree-wide: Use get() helper instead of direct access
internal/sdref: Remove in favor of stdplus/handle
source/base: Remove unused ref constructor
tree-wide: Use cexec for checking calls
sdevent: Fix missing parameter names
(From meta-phosphor rev: 36fb2808506aeec25b82ad7224259b0c1f7749ca)
Change-Id: Ic0ab7e529c112604c29e0f7e50fe025641880c9e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (3):
handle/managed: Implement non-copyable handle
handle/copyable: Implement copyable handle
util/cexec: Implement exception helpers
(From meta-phosphor rev: 80bb91ea494909122a919d86c05f986da81c59af)
Change-Id: I28d0db0b0dca3804283f89962e9f0a3bd8f61495
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
meson: Add version to library
(From meta-phosphor rev: a2637b220a53ed02f8801f9ef10201bec9f162db)
Change-Id: Iec2514a3741633fda3d6f98789bf758c5028ba9a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
meson: Add version to library
(From meta-phosphor rev: 611a4d6b4f562ceadd1a912b9e147df7236285b8)
Change-Id: Iff078a4741573877f60346c5e9df3abbc41018ee
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
William A. Kennington III (1):
meson: Add build system
(From meta-phosphor rev: 1d9f2c644dd4f7ef1cbf91942cd9a0913ca29760)
Change-Id: I73affc91db03f0ff71473ceb7a2c3dd0db551b82
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
An upcoming change will require stdplus as a new dependency
(From meta-phosphor rev: eceabb734b586759e70a73fde40d9bccc390c089)
Change-Id: I75f6d0e4c49851819c3ac2eb025a1a5b1ab27564
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
The previous change committed a bad checksum for the license file.
(From meta-phosphor rev: d2237f75eb22cac6a2e78646c45e8217e2c50ada)
Change-Id: Ia731a291fa0d359a3eddd0e37ca573c2888ec4f9
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Ideally this would be using meson but our current version 0.47.2 is not
new enough to support that yet.
(From meta-phosphor rev: ed59c49fac0f553d626e1e3400e3e38f23248791)
Change-Id: Iaaa2d3cdc92edf60c82c0b2ddca3d332b4cdac9d
Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Ed Tanous (2):
Move to modern asio interfaces
Fix warnings in forward declarations
(From meta-phosphor rev: ff63304199075e543f650749ad78cce7cbd538e9)
Change-Id: I596e619427d3538911dea9aa7b4f701109528417
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Richard Marian Thomaiyar (1):
sdbusplus: Provide option to skip signal property
(From meta-phosphor rev: 5f272f04b513c4071502a03a2d2c2a5d4b434495)
Change-Id: I273ee9f247c8d0c008ef32f36f762ae25c4426ef
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
William A. Kennington III (1):
autotools: Fix for autoconf-archive 2019.01.19
(From meta-phosphor rev: 339048abb8eb593cc2ac76588bd4994d7fb6d239)
Change-Id: I32fdd72649561b51a387c6c10048856c5795221d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
William A. Kennington III (1):
autotools: Fix for autoconf-archive 2019.01.19
(From meta-phosphor rev: 5aae8ca326d1c32d6bd7aa9632a06c76f5b282b7)
Change-Id: I112abc3609fa5b67d4598fec019d515a232f3c9c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
William A. Kennington III (2):
meson: Add alternative build system
clang-tidy: Basic configuration
(From meta-phosphor rev: 27ea2d76a6c144b0290872dfaf5248c771db2114)
Change-Id: Id48cc18fd489ee5ff0307950f89d5aa35c4c9628
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
William A. Kennington III (1):
bus: Add chrono types for timeouts
(From meta-phosphor rev: 8e796a400c632cba99caf5e586ddcc330d34c6fa)
Change-Id: Ia721e75ff7cd5075ccc57aaea0de31ec9adc1b0a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
William A. Kennington III (1):
autotools: Fix for autoconf-archive 2019.01.19
(From meta-phosphor rev: 65d6bac518f11b8a51f16287ca8445b128cbe34d)
Change-Id: Ia6f6af861ee9c7a67d198bbd6f60bf101846945e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Vernon Mauery (1):
sd_event_wrapper must not close descriptor
(From meta-phosphor rev: 5886d0f5cee0fc1864f6cd7cc7641feab3535e21)
Change-Id: If6c7c7347aac1d5909f08615da519be7a7886660
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Waqar Hameed (1):
message: Add constructor with an int parameter for unix_fd
(From meta-phosphor rev: 3701643d8d0610ddd61b15d02159daff10503268)
Change-Id: I5ea27ea02f0dc4afca5233c33c6c1e982fa19e9d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Absence of ldap distro feature will not generate pam_ldap.so because
of which we might see some unwanted error messages regarding the
failure in opening the pam_ldap.so in journalctl incase if pam_ldap
is present in PAM Configuration.
This commit would:
- Leverage '-' option before the 'type' in pam configuration, by which
the PAM library will not log any errors in the syslog if it is not
able to load the module beacause it is missing in the system.By using
this we don't need two pam configuration files for ldap and unix.
- Leverages ignore_unknown_user & ignore_authinfo_unavail options of
pam_ldap.so, which forces the PAM framework to ignore pam_ldap incase
if the user is not present in LDAP server or if the client cannot
connect to LDAP Server.
(From meta-phosphor rev: 2c7efc937785a76e35a06b6807e12765ad40d99d)
Change-Id: Ic1044989ccae4e6e442de9865cf00cea33f75262
Signed-off-by: manojkiraneda <manojkiran.eda@gmail.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|