| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
obmc-ikvm runs with two seprated thread to handle connection from user
(bmcweb::kvm_websocket) and video device (libvncserver), however both
these two thread access to rfb*() API. It leads to client socket double
free issue.
cl->sock has been set to RFB_INVALID_SOCKET(-1) with first clientClose
call.
And the second call to clientClose uses -1 in FD_CLR() generates buffer
overflow.
```
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbClientConnectionGone: c1=75900748
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbClientConnectionGone: c1=75900748
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbSendUpdateBuf: write: Broken pipe
obmc-ikvm[672]: *** buffer overflow detected ***: terminated
systemd[1]: start-ipkvm.service: Main process exited, code=dumped,
status=6/ABRT
systemd[1]: start-ipkvm.service: Failed with result 'core-dump'.
systemd[1]: start-ipkvm.service: Scheduled restart job, restart counter
is at 1.
systemd[1]: Stopped OpenBMC ipKVM daemon.
```
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Change-Id: I4bbe69c6d7006e44c5f4a532fb54f9ae9c9cd52b
|
|
PACKAGECONFIGs are added upstream frequently. Avoid new implicit
dependencies by pinning to the exact options required by OpenBMC today.
(From meta-phosphor rev: a604537070251e0a391b3eccf3a0c6b9d528a5ae)
Change-Id: Id89749f408512118ce2a29a71f3f033fd79a3221
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Add the application recipe and service to start application when the
BMC boots. Append the libvncserver depdendency to minimize the image
size impact.
(From meta-phosphor rev: 1205c5b25ae674cdd568ed8cbdfa99f3ea7ba788)
Change-Id: I7791f3512e9ba7a33d95df7ea30d0dc48a218d2f
Signed-off-by: Eddie James <eajames@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
