Age | Commit message (Collapse) | Author | Files | Lines |
|
obmc-ikvm runs with two seprated thread to handle connection from user
(bmcweb::kvm_websocket) and video device (libvncserver), however both
these two thread access to rfb*() API. It leads to client socket double
free issue.
cl->sock has been set to RFB_INVALID_SOCKET(-1) with first clientClose
call.
And the second call to clientClose uses -1 in FD_CLR() generates buffer
overflow.
```
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbClientConnectionGone: c1=75900748
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbClientConnectionGone: c1=75900748
obmc-ikvm[672]: 24/08/2021 08:45:11 rfbSendUpdateBuf: write: Broken pipe
obmc-ikvm[672]: *** buffer overflow detected ***: terminated
systemd[1]: start-ipkvm.service: Main process exited, code=dumped,
status=6/ABRT
systemd[1]: start-ipkvm.service: Failed with result 'core-dump'.
systemd[1]: start-ipkvm.service: Scheduled restart job, restart counter
is at 1.
systemd[1]: Stopped OpenBMC ipKVM daemon.
```
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Change-Id: I4bbe69c6d7006e44c5f4a532fb54f9ae9c9cd52b
|
|
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I588025b614416c43aa2d053765ab53bacf890cb5
|
|
Paul Fertser (1):
Implement optional per-frame CRC calculation to save bandwidth
Change-Id: I7396e6320ebebd1f815dd25b4bdc3a1d23e7889d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Bruce Mitchell (1):
Replace IRC with Discord
Change-Id: I4b05d26c5d86cef44d00d518fe4345eb9602b52e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zev Weiss (1):
Fix error reporting in Input::writeKeyboard()
Change-Id: I413ff364543912fbcee0c3186e10e8fe3087a9b3
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Reducing the installed font set is not version specific, apply even to
updated versions.
Change-Id: Iddf03fb64cc43d49a4c94d480d141352a300a831
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
Jae Hyun Yoo (3):
Fix keyboard and mouse input events dropping issue
Connect HID gadget device dynamically
Refine HID report writing logic
Change-Id: I58f99acff409b1b5063762049d9f73e206a83804
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
PACKAGECONFIGs are added upstream frequently. Avoid new implicit
dependencies by pinning to the exact options required by OpenBMC today.
(From meta-phosphor rev: a604537070251e0a391b3eccf3a0c6b9d528a5ae)
Change-Id: Id89749f408512118ce2a29a71f3f033fd79a3221
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Brad Bishop (2):
build: drop autotools support
systemd: Don't start without configfs
(From meta-phosphor rev: e69bb0770514913d99035874515e4aff57fda810)
Change-Id: Ifb12eb7ec47baaa3efb22a89a2860ed5f30967ea
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Eddie James (1):
Prevent excessive journal logging by wakeup signal
(From meta-phosphor rev: 6383ea303593962e9aea0504fa4abb55b10b371f)
Change-Id: I8b45dcb23faa410f1e391fc91b3d423f336e86de
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Jae Hyun Yoo (2):
Add flow control to prevent buffer over run
Remove frame rate limit
(From meta-phosphor rev: 1a115b92749bb063bd65cc2a7922513b91c82d1f)
Change-Id: Ic3a58ecd70add1b16ef25aa89a55147db6a1e91b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Jae Hyun Yoo (1):
Add keypad input support
(From meta-phosphor rev: b9f44a09def5c5b678048263c34938737149a3fc)
Change-Id: I9d16fffc9bd81977c27cae4fe1d307b0c114c56e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Jae Hyun Yoo (1):
Add a maintainer
(From meta-phosphor rev: 46e844f76f17b43f31a290812d5d7cc9e196f08e)
Change-Id: I5000da39a5aa927635888363e85c5c12561e4a5a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Eddie James (1):
eliminate excessive journal errors
(From meta-phosphor rev: cfc9abf9f77ee17c73ed3dddc21b4b5e426e3599)
Change-Id: Icf4d451a413aef0c0b8efa3bbc7a4b4173000b39
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Eddie James (1):
Reduce framerate to prevent lag
(From meta-phosphor rev: 80933683ba0c680998c7becfaf7bb92ea10a5f42)
Change-Id: Ic18e38bd02d945f1fee5cc32af40e5e38f8c2d12
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Eddie James (1):
Switch pointer gadget to non-blocking
(From meta-phosphor rev: 9a0ba9e589db99cbe6d4e3e54280a05b59e29344)
Change-Id: I1d9977419a781785ed94ff5b9dc227360e6cb2bd
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Jae Hyun Yoo (1):
Fix host video wake up failure issue
John Wang (1):
meson: install create_usbhid.sh
(From meta-phosphor rev: 3a14f052d9d31f33458c3accd3f2d0308595694d)
Change-Id: I22964508a850d7b97021b63f7394760a75a7789d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Add the application recipe and service to start application when the
BMC boots. Append the libvncserver depdendency to minimize the image
size impact.
(From meta-phosphor rev: 1205c5b25ae674cdd568ed8cbdfa99f3ea7ba788)
Change-Id: I7791f3512e9ba7a33d95df7ea30d0dc48a218d2f
Signed-off-by: Eddie James <eajames@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|