Age | Commit message (Collapse) | Author | Files | Lines |
|
Current realization of a boot override feature has several downsides
which are described in detail in the mailing list letter
https://lists.ozlabs.org/pipermail/openbmc/2021-May/026533.html
Redesign interfaces under '/xyz/openbmc_project/control/host0/boot'
object to solve all the problems, in particular:
- add 'Enable' interface under '/xyz/openbmc_project/control/host0/boot'
path to store overall boot override enabled state,
- drop BootSource/BootMode/BootType interfaces from the
'/xyz/openbmc_project/control/host0/boot/one_time' object. In the new
design there is no need to store such properties twice,
- by default make override feature disabled and permanent.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: Ie59ba703a6f39f8e1d4934cce89cbe8cd5a826e4
|
|
The following commit introduced a new enum value for power restore:
https://github.com/openbmc/phosphor-dbus-interfaces/commit/66b591e165b53a80e431a543aa8c8e48beba585f
This new "None" value indicates to the power restore logic that the
one_time setting should be ignored. Make this the default so one_time is
ignored until something changes it.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I47784937038ee76982fede0dd53664f6f4d0181b
|
|
IBM has a use case where it wishes to utilize the power-restore
functionality for a firmware update path. A firmware update
is initiated through the host operating system. Once it has completed
writing the BMC flash, the host wants to initiated a power off of the
system, a reboot of the BMC, and then an automatic power on of the host.
Instead of writing special software to handle this automatic boot of the
host after the BMC has rebooted, lets utilize a one_time setting within
the power-restore logic.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I4964004e3b1827853ff00437172196e4fbbfcc46
|
|
IBM has a use case where boots of a system can be done utilizing a debug
tool called istep. This tool does not utilize the normal systemd targets
to boot the system, but instead launches each individual step required
to boot the system. This allows fine grained control of the boot and the
ability to easily debug issues.
When booting a system using this tool, it is required that the automated
reboot policy be off. The issue is that istep can easily set AutoReboot
to false when it is used, but there is no way for it to know when to reset
it to true (i.e. when the user is done).
AutoReboot is a user setting and is something that must stay persistent
based on the users selection. It should not be moved back and forth by
software based on different debug modes.
The solution proposed here is to make a one-time AutoReboot property.
Boot debug tools like istep can utilize this temporary property and be
confident it will be reset whenever the user powers down their system or
stops their host.
Software will first look at this new one-time reboot property. If false
then auto reboots will be disabled. If the temporary reboot property is
true then software will look at the user-based AutoReboot property for
direction.
This new property will have no impact to existing software unless it
gets set and something looks at it. The thought is this could be useful
to more then IBM, so proposing it initially in meta-phosphor.
(From meta-phosphor rev: 7d29e7a2c135e91b222c57c66bb7ca61aae6398e)
Change-Id: I7c542469135061c5b5017b87cffc92aa6b8794c4
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
The TimeOwner feature is confusing from feedback from the community and
we should be removed.
(From meta-phosphor rev: 4cd09c85f3d168cef02d2a020ef93b718f3a3456)
Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I5ceff148059337df1c41cb54b2bb3080df1aca69
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
See the following design doc for more info:
https://github.com/openbmc/docs/blob/master/designs/fail-boot-on-hw-error.md
The new D-Bus interface is defined here:
https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Logging/Settings.interface.yaml
(From meta-phosphor rev: 6f5102fa5e2adc8451aa81ad08309f08fbf131b4)
Change-Id: Idc6f2ae909216222dc8b1ac25ccc959c95abe347
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
(From meta-phosphor rev: f0497ff5675e265fa0201d0cf06b0552a720e227)
Change-Id: If055b00987bccbd9cea519dc38b5c3cd92521451
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
|
Change the default TimeOwner from BMC to Both in phosphor-settings.
Tested: tested on fp5280g2. The default Timer owner has changed to Both.
(From meta-phosphor rev: 45efbb4ae2d518abae1ba8f6dd7ca9278ee3ed69)
Signed-off-by: Albert Zhang <zhanghaodi@inspur.com>
Change-Id: I531a15cbd5e87aaf5d481f073ea884c412a93ccb
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Setting a default value for ApplyTime property which can control when
to apply the newly uploaded software image. The ApplyTime property is
defined in the UpdateService redfish schema. This property will be hosted
from phosphor-settingsd with a default value as OnReset.
Tested: Verified that the property is getting created with the expected
default value as OnReset.
busctl get-property xyz.openbmc_project.Settings
/xyz/openbmc_project/software/apply_time
xyz.openbmc_project.Software.ApplyTime RequestedApplyTimes
"xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.OnReset"
(From meta-phosphor rev: 634e8d0c70ad2c7732e13439fcbca569457919a5)
Signed-off-by: Jayashankar Padath <jayashankar.padath@in.ibm.com>
Change-Id: Iadb744fe4c1db39fb758758f47b64205be0110af
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
It may be desirable for the rest server implementation to log rest calls
for audit purposes, and further, it is desirable for a user to turn this
feature on/off.
Add a D-Bus setting for the same, which a rest server can look up and
turn on logging, if required. Turn logging off, by default.
Commit 6e1ca53 in the phosphor-rest-server implements logging. A
subsequent commit will control logging based on this setting.
(From meta-phosphor rev: dcc1bdb90e78264ad1a30d4cfc62dafe3fb1652d)
Change-Id: I183986116e9472c503bc06bb3d679a8de82a3a8f
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Add the power supply derating factor property to the settings
interface with a default value of 90 (reference the variable
POWER_SUPPLY_DERATING_FACTOR in openbmc/openbmc).
This setting will be used by IPMI to get the derating factor
value when the Host requests it via a get sensor command.
Tested: Verified the new property was created with its default value.
(From meta-phosphor rev: 5dce67a520d2096ea91eb55734de6ba0e9a718f7)
Change-Id: Ia1e2ce66014bf4d7d4bf1ac9780d0ab11a60988f
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
Adopt a more conventional directory hierarchy. meta-phosphor is still
a _long_ way from suitable for hosting on yoctoproject.org but things
like this don't help.
(From meta-phosphor rev: 471cfcefa74b8c7ceb704cb670e6d915cf27c63b)
Change-Id: I3f106b2f6cdc6cec734be28a6090800546f362eb
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|