summaryrefslogtreecommitdiff
path: root/meta-phosphor/recipes-phosphor
AgeCommit message (Collapse)AuthorFilesLines
2021-05-08phosphor-bmc-code-mgmt: srcrev bump 6e9fb1d6ec..cfb4b2099fAndrew Geissler1-1/+1
Lei YU (1): item_updater: Fix crash on redundantPriority Change-Id: I08053ba1860c7835d166bdbe33fe61cd2eda1cf5 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-07phosphor-host-ipmid: Add option for configuring dynamic sensorsWilliam A. Kennington III1-0/+3
This makes it possible to enable or disable dynamic sensors. By default this is now disabled as it is a new feature that is not compatible with static sensor stacks. Change-Id: I55fea70642cee4d68153c402478483603805c601 Signed-off-by: William A. Kennington III <wak@google.com>
2021-05-07phosphor-hwmon: srcrev bump d46d08 | create busconfig based on env cfgAnton D. Kachalov1-1/+49
Anton D. Kachalov (1): Add sensor instance id command line argument. This change will generate busconfig ACLs from the provided hwmon environment files from /etc/default/obmc/hwmon that will be supplied as "sensor-id" argument to hwmon daemon. This change required as a part of privilege separation work: https://github.com/openbmc/openbmc/issues/3383 This change should be merged after individual repo change: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-hwmon/+/40214 Signed-off-by: Anton D. Kachalov <gmouse@google.com> Change-Id: I37c31d6f2f74041bfee453bdf338d4c7e148c791
2021-05-07phosphor-hwmon: install configs from repoAnton D. Kachalov6-67/+7
Use meson to build the package. This change required as a part of privilege separation work: https://github.com/openbmc/openbmc/issues/3383 This change should be merged after individual repo change: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-hwmon/+/40277 Signed-off-by: Anton D. Kachalov <gmouse@google.com> Change-Id: I542645d55b8646e0ddb3fb95f50a1cd87334706e
2021-05-07phosphor-hwmon: srcrev bump 6f42e3568f..5b520cf494Andrew Geissler1-1/+1
Anton D. Kachalov (1): Install service unit files, busconfig and udev rules from the package. William A. Kennington III (4): gitignore: Ignore all build directories meson: Cleanup library linking meson: Explicitly check for CLI11 dependency meson: Cleanup tests and make them execute again Change-Id: I26d3f28adb2ecb9b96b27bfd082ab8c3dac921f9 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-07phosphor-host-ipmid: srcrev bump 7345ac4192..a55c953dd2Andrew Geissler1-1/+1
Josh Lehan (1): sensorcommands: Add IPMI reading logging instrumentation Konstantin Aladyshev (2): sensordatahandler: Set data unavailable if value is NaN sensorhandler: Support 0 value for thresholds Kuiying Wang (1): dbus-sdr: Fix sensor missing issue. Change-Id: I6e36eb517af976080ab338f9f6b92a7aec22d1dc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-07debug-collector: Fix unclosed file in bb fileGeorge Liu1-0/+1
- The intent behind this commit is to fix the unclosed file in the phosphor-debug-collector_git.bb file. - When using `bitbake phosphor-debug-collector` to compile it, the warning message is: ResourceWarning: unclosed file <_io.TextIOWrapper name='phosphor-debug-collector/tools/dreport.d/plugins.d/hostlogger' mode='r' encoding='UTF-8'> install_dreport_user_script(srcname, d) Tested: built phosphor-debug-collector successfully and worked. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Id95b4a6369571db876acee0ed90953cd3874fff1
2021-05-07dbus-sensors: srcrev bump 6b6891c52e..b89967ffa4Andrew Geissler1-1/+1
Bruce Mitchell (1): Replace IRC with Discord Change-Id: I46d3aab8f09a12a4f44ea81b81899cf4df47ba72 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-07webui-vue: srcrev bump 5ed21f2d1e..15bcc41f74Andrew Geissler1-1/+1
Alicja Rybak (1): Fix toast message for VM Legacy successful mount Derick Montague (1): Replace the use of the term host with server Change-Id: I501d5524489648ab0747c1efd6830a5bc69695fc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-06phosphor-certificate-manager: srcrev bump 641a559eea..dc91fb61e5Andrew Geissler1-1/+1
Jayanth Othayoth (1): Add fix for Missing "OU" OrganizationalUnit CSR Change-Id: I6cae0e80e88bf1057e9ce87c92a956eb90855637 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-06pldm: srcrev bump cfff3e9c1b..50304da5f2Andrew Geissler1-1/+1
Jayashankar Padath (1): pdr: Sensor/Effecter support for enc fault and identify leds Varsha Kaverappa (1): PDR/Sensor/Effecter for BMC owned LEDs Change-Id: Ie42ec8e56c4d5b9cf9ea3c94b907be5c44acd86d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-06phosphor-logging: srcrev bump ef9cc07e13..81b4dcabb7Andrew Geissler1-1/+1
Vijay Lobo (1): PEL: Update filling VPD fields in PEL Change-Id: I2c97890461d710dd0e3229aa14b1efbb1b3a6bc6 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05phosphor-user-manager: srcrev bump 18c1b42c16..e6500a493aAndrew Geissler1-1/+1
Patrick Williams (1): use new sdbus++ camelcase Change-Id: I17530552911e599b173090cf890c1314a8b4cea4 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05phosphor-logging: srcrev bump 011ccae099..ef9cc07e13Andrew Geissler1-1/+1
Patrick Williams (1): build: remove autotools support Change-Id: Ia3718a6cff429e85e8044a0dbb48254d53c51a80 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05bmcweb: srcrev bump d3d26ba270..ffed87b5adAndrew Geissler1-1/+1
Ed Tanous (1): Fix chassis handler to use filename() Manojkiran Eda (1): Change the word TS to Time Stamp & add time unit Change-Id: I1e32f43e83a604eff763ca5756a7efa3284d020d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05pldm: srcrev bump 47cf663e2a..cfff3e9c1bAndrew Geissler1-1/+1
Jayashankar Padath (1): bios: Add/change bios attributes Change-Id: Icd1515869ed2e2a39c7bb9cf8eb1ac2fb6512608 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05phosphor-led-manager: srcrev bump 2c211f8c2c..e367ceaecfAndrew Geissler1-1/+1
George Liu (1): meson: switch to 0.57.0 Change-Id: I366f8e1d2bc5f2e21f1fa696b76ed9eb9e9f6123 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05phosphor-host-ipmid: srcrev bump 916d4232a4..7345ac4192Andrew Geissler1-1/+1
Patrick Williams (1): use new sdbus++ camelcase Change-Id: I9f5515bfdf978284c37e01e167c02b4afa2c6fbd Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-05phosphor-settingsd: srcrev bump 9cca1ef0b1..b41b1e4b7fAndrew Geissler1-1/+1
Patrick Williams (1): bootstrap: fix shellcheck warnings Change-Id: I4c12837a10af1d998dbe67a8fea6769ed68f81b7 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04phosphor-state-manager: srcrev bump aaa2e11057..45a1ed71bcAndrew Geissler1-1/+1
Patrick Williams (1): use new sdbus++ camelcase for POHCounter Change-Id: Ia7af3db049ecfbeaeb33c50f9b6634793a5b52ae Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04phosphor-led-manager: srcrev bump e2060f3c44..2c211f8c2cAndrew Geissler1-1/+1
Vishwanatha Subbanna (1): Configs: Everest: Remove LCD display unit indicator LED Change-Id: I0b1ed32e97d2b55c93b08f6229b4d8baac73126b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04phosphor-certificate-manager: srcrev bump 86a31ba594..641a559eeaAndrew Geissler1-1/+1
Patrick Williams (3): use new sdbus++ camelcase for CSR. MAINTAINERS: update for Ed MAINTAINERS: update for Deepak Change-Id: I3b3ba3e96bff657aeb2e159ad73f4aa22e4fcda2 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04phosphor-logging: srcrev bump 60356ad409..011ccae099Andrew Geissler1-1/+1
Miguel Gomez (1): Add a termination error display option in peltool Change-Id: I1bdb2041a3852f0479785dfb6e9513ad01f5179d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04entity-manager: srcrev bump 98e102f377..37e142be0fAndrew Geissler1-1/+1
Ed Tanous (1): Check for errors before trying to open a bus Change-Id: I9272ce7333cf4b0ad5101fa2172357c754e458c4 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-04phosphor-power: srcrev bump 2f9e14f632..6d5470d054Andrew Geissler1-1/+1
Shawn McCarney (3): regulators: Add inventory_path to JSON chassis obj regulators: Add inventory path to Chassis class regulators: Update sensor monitoring documentation Change-Id: I1516629ff0e6baae16e506aaa57c6a4fdf0070ba Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-03phosphor-mmc-init: Determine EFI partition presence via exit codeAndrew Jeffery1-2/+1
Testing if $magic is empty is an indirect test of whether the grep succeeded. Instead, just use the grep exit code. Change-Id: I3eba40e8b54863ab9a1a4436f1419b69c5bea8e1 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
2021-05-03phosphor-logging: convert to mesonPatrick Williams1-13/+7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I2a5eb57d100ced02043bf68f64e4596c59da6ebd
2021-05-01phosphor-logging: srcrev bump a1c4338ece..60356ad409Andrew Geissler1-1/+1
Patrick Williams (7): build: meson support for libphosphor-logging build: meson support for phosphor-log-manager build: meson support for test-utils build: meson support for unit tests build: meson support for rsyslog-config build: meson support for openpower-pel extensions build: adjust meson dependency for cereal Change-Id: I380f33f291bc85a43212db2ab4b41dfb49195a80 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-01phosphor-hwmon: srcrev bump 8fa48a46b4..6f42e3568fAndrew Geissler1-1/+1
Matt Spinler (2): Change #ifdef to #if after move to meson Remove autotools files Change-Id: I8f22b9ef4ea0ab080ef7a3836e7a81b4d3335da2 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-01bmcweb: srcrev bump f65b0bead8..d3d26ba270Andrew Geissler1-1/+1
Ali Ahmed (1): Fix typos in comments Change-Id: Ifeaede62ba83f55877f9bfb55c0ad2b5ffefc024 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-01phosphor-dbus-interfaces: srcrev bump 5d0b767aeb..33458d4432Andrew Geissler1-1/+1
Chris Cain (1): Control.Power.Mode: Add System Power Mode Interface YAML Jonathan Doman (1): Add UniqueIdentifier interface Patrick Williams (1): build: minor fix to meson regen script changing Change-Id: I3e6711e4bb7e5db68523b1cb28280d04c051a664 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-01phosphor-led-manager: srcrev bump 7907827126..e2060f3c44Andrew Geissler1-1/+1
Vishwanatha Subbanna (1): Configs: Rainier: Add led group json for Rainier 1S4U system Change-Id: I0c67d75a440aa222e8b7a6b24c0bc76ce961432d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-01phosphor-snmp: srcrev bump 0d5094bf65..33a34f04baAndrew Geissler1-1/+1
Patrick Williams (1): bootstrap: fix shellcheck warnings Change-Id: I9748c5ec4f057b8db2d963597d918500f7869d8f Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-dbus-interfaces and phosphor-inventory-manager bumpAndrew Geissler2-2/+2
phosphor-dbus-interfaces: srcrev bump 32fbd5df09..5d0b767aeb Alpana Kumari (1): InventoryItemDimm: Change the type of 'MemorySizeInKB' Andrew Geissler (1): host: define new interface for checking condition Patrick Williams (1): Sensor.Value: add defaults for min/max phosphor-inventory-manager: srcrev bump 21e72fb2a5..ab1f8b520a Alpana Kumari (1): Support Variant Type size_t Change-Id: I189ab6583b43d36ec58d55c857220fb388799f78 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-mmc-init: exec switch_root(8) rather than chroot(1)Andrew Jeffery1-1/+1
It was found that perf(1) had some issues with recording and analysing data on Rainier systems: ``` root@rainier:~# perf probe --add mem_serial_in root@rainier:~# perf record -e probe:mem_serial_in -aR sleep 1 [ perf record: Woken up 1 times to write data ] assertion failed at util/namespaces.c:257 No kallsyms or vmlinux with build-id e4e9c7cff1deb3bf32958039c696f094dc76cf5c was found [ perf record: Captured and wrote 0.377 MB perf.data (25 samples) ] root@rainier:~# perf script -v build id event received for [kernel.kallsyms]: e4e9c7cff1deb3bf32958039c696f094dc76cf5c broken or missing trace data incompatible file format (rerun with -v to learn more) ``` Starting with the failed assertion in the recording, we find the relevant code is the following WARN_ON_ONCE(): ``` void nsinfo__mountns_exit(struct nscookie *nc) { ... if (nc->oldcwd) { WARN_ON_ONCE(chdir(nc->oldcwd)); zfree(&nc->oldcwd); } ``` A strace of `perf record` demonstrates the relevant syscall sequence, where /home/root is the working directory at the time when `perf record` is invoked. ``` openat(AT_FDCWD, "/proc/self/ns/mnt", O_RDONLY|O_LARGEFILE) = 12 openat(AT_FDCWD, "/proc/142/ns/mnt", O_RDONLY|O_LARGEFILE) = 13 setns(13, CLONE_NEWNS) = 0 statx(AT_FDCWD, "/mnt/rofs/bin/udevadm", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT, STATX_BASIC_STATS, {stx_mask=STATX_BASIC_STATS|0x1000, stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=978616, ...}) = 0 openat(AT_FDCWD, "/mnt/rofs/bin/udevadm", O_RDONLY|O_LARGEFILE|O_CLOEXEC) = 14 setns(12, CLONE_NEWNS) = 0 chdir("/home/root") = -1 ENOENT (No such file or directory) ``` From the path of the binary, PID 142 is executing in an unanticipated environment. Its path is representative of the state of the filesystem prior to the initramfs handing over to /sbin/init in the real root, suggesting an issue with the initramfs' /init implementation. In /init we find a bunch of setup to discover and mount the root device. At the end of the script we prepare for the real root by exec'ing chroot. From `man 2 chroot`[0]: ``` DESCRIPTION chroot() changes the root directory of the calling process to that speci‐ fied in path. This directory will be used for pathnames beginning with /. The root directory is inherited by all children of the calling process. ``` Specifically, this outlines that chroot(2) affects the state of the calling *process* and not the state of mount namespace in use by the process. Further, a call to `setns(..., CLONE_NEWNS)` explicitly replaces the mount namespace for the *process*, and as such destroys any chroot state that might have been associated with the process' original mount namespace. As the chroot state is not a property of a mount namespace, switching *back* to the application's original mount namespace does not restore the process' original chroot state. As such, the chdir(2) from the strace output above returns an error, as the get_current_dir_name(3) call that yielded the provided path was issued prior to switching into the target process' mount namespace, and was thus derived in the chroot context. The path is therefore invalid once the original mount namespace is restored via the second setns(2) as the process has (already) lost the chroot context for the original namespace. For perf(1) to work in its current implementation the effective root for PID 1 must remain the absolute path "/" with respect to the kernel's VFS layer. This requires /init to use either pivot_root(1) or switch_root(1). pivot_root(1) is ruled out by its own man-page[1]: ``` NOTES ... The rootfs (initial ramfs) cannot be pivot_root()ed. The recommended method of changing the root filesystem in this case is to delete every‐ thing in rootfs, overmount rootfs with the new root, attach stdin/std‐ out/stderr to the new /dev/console, and exec the new init(1). Helper pro‐ grams for this process exist; see switch_root(8). ... ``` As noted, the recommendation is a description of the switch_root(8) application[2]. The details of why the specific sequence for switch_root(8) is necessary is documented in [3]. Change /init to use switch_root(8) to avoid the nasty interaction of chroot(2) and setns(2). [0] https://man7.org/linux/man-pages/man2/chroot.2.html#DESCRIPTION [1] https://man7.org/linux/man-pages/man2/pivot_root.2.html#NOTES [2] https://man7.org/linux/man-pages/man8/switch_root.8.html [3] https://git.busybox.net/busybox/tree/util-linux/switch_root.c?h=1_32_1#n298 Change-Id: Iac29b53a462b03559d18fe9b600aefcd1951057e Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
2021-04-30kcsbridge: srcrev bump 4a4d1d03d9..3b170152ddAndrew Geissler1-1/+1
Patrick Williams (1): bootstrap: fix shellcheck warnings Change-Id: I4e14b5fb556a03c254253aa3da8cd0ca7b1140b1 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30pldm: srcrev bump ada39c0f5d..47cf663e2aAndrew Geissler1-1/+1
Roland Veloz (1): pldmbios: Adding a BIOS attribute that can limit the number of cores activated Change-Id: I64738d5997a677d06755cae141ceb8d8ba1233cc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-ipmi-blobs: srcrev bump a533a3756f..52b75fb392Andrew Geissler1-1/+1
Willy Tu (1): test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD Change-Id: I010483a6110a394aed137308cf91bdef968bdb2e Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30pldm: srcrev bump c038bac2bf..ada39c0f5dAndrew Geissler1-1/+1
Pavithra Barithaya (1): PLDM: Remove Boot Progress entry from 11.json Change-Id: I9112c4995f62d25f8ef314659133c68be2b3574b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30obmc-console: srcrev bump d802b11942..cabd9db06dAndrew Geissler1-1/+1
Patrick Williams (1): bootstrap: fix shellcheck warnings Change-Id: Ib15357fce19134618d9a1fc1a77472d3af7a078d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-ipmi-flash: srcrev bump a3f6569800..f450486f23Andrew Geissler1-1/+1
Willy Tu (1): test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD Change-Id: Iecc9bfbacc31d9e9f3664740aa0110341efd382a Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30entity-manager: srcrev bump 478cfd2c31..98e102f377Andrew Geissler1-1/+1
Ed Tanous (1): Apply autojson to all existing configurations Change-Id: Ic370d2239238fb61abb339604ba197d34e19667a Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-virtual-sensor: srcrev bump d9aa22790f..543bf66877Andrew Geissler1-1/+1
Harvey Wu (1): Add MaxValue/MinValue setting in config Patrick Williams (1): add clamping of min/max Change-Id: I211e030021d95eeaa8378bd4cdcca4a6f64a90e1 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30phosphor-power: srcrev bump 8279a11d64..2f9e14f632Andrew Geissler1-1/+1
Shawn McCarney (2): regulators: Remove SensorReading data type regulators: Convert to new SensorType enumeration Change-Id: I4437444e80b5e2a8e4e691ca764d36874021616b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-30bmcweb: srcrev bump d4b6c66034..f65b0bead8Andrew Geissler1-1/+1
Chicago Duan (1): Redfish: Fix the health and state properties of processor Ivan Mikhaylov (1): bmcweb: fetch ip address on every request in handle Noah Brewer (1): Redfish: Update Powering On Status State Change-Id: If55fa3b7c6725e7f8d1e50e7e1fd1f8eadf5a6f9 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-29phosphor-fan-presence: srcrev bump 4031f10629..a4386a3e91Andrew Geissler1-1/+1
Matt Spinler (1): docs: Update presence GPIO I2C path Change-Id: I6ce3b54616276bce9af78f1a3360f5b41b46e5dc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-29phosphor-certificate-manager: srcrev bump ebd1d8a829..86a31ba594Andrew Geissler1-1/+1
Ravi Teja (2): CA Certs: Modify object entry path to fix object sub-tree hierarchy CA Cert: Fix D-bus object path Change-Id: Ic4e436a9d53a070f0d77e8385b59ccee72ce21bc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-29btbridge: srcrev bump aa5511d28f..0a47d9a057Andrew Geissler1-1/+1
Patrick Williams (2): bootstrap: fix shellcheck warnings enable shellcheck Change-Id: I07d94247a32e6d4445ed41a10aeaf60c78ccb824 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-29phosphor-led-sysfs: srcrev bump 07758dcaa3..fcc56b6705Andrew Geissler1-1/+1
Patrick Williams (1): bootstrap: fix shellcheck warnings Change-Id: I4e2520684dc4db95c83ea594b0dba5ddbfddc5fa Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-29phosphor-power: srcrev bump 837ece7cdf..8279a11d64Andrew Geissler1-1/+1
Shawn McCarney (3): regulators: Create DBusSensors class regulators: Remove Services& from Sensors methods regulators: Add Sensors to Services hierarchy Change-Id: I4e071b4b28dd8017221b4ab87813ad751b36a864 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>