BMC/Intel-BMC/openbmc.git - Intel-BMC/openbmc is a BMC implementation for servers (mirror)

Age	Commit message (Collapse)	Author	Files	Lines
2020-11-03	Revert "Move context and coroutine"	Andrew Geissler	1	-5/+7
	This reverts commit 6be1787fdc13405fa9daa6755c28534bbcaa7458. openbmc/openbmc#3720 tracks the issue we've been having with the latest poky update. For now we're going to have to revert it which means we need to go back to handling the older boost. Lets revert this so we go back to not minimizing our boost library which will cause a bit larger library in flash but allow us to support both the old and new boost packaging. (From meta-phosphor rev: 3ee1f9df23ab04871297676c265dfcf0a8db38f4) Change-Id: Ib45de998931142ea74dffddafd960b7513717a18 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-10-21	Move context and coroutine	Ed Tanous	1	-7/+5
	Yocto upstream moved context and coroutine directly into BOOST_LIBS, which means that they're not added back for our arm variant. https://github.com/lgirdk/poky/commit/624262541605c476f5a0bd415b08d00379c15b00 This causes our build to fail with "cannot find -lboost_coroutine" errors. This should resolve it. Tested: Fixing CI break. No functional testing done. (From meta-phosphor rev: 6be1787fdc13405fa9daa6755c28534bbcaa7458) Signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I60d7bb8ea25a08bfdb399f8addfaf560fd7a7b7c Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-10-19	boost: temp fix for upstream yocto boost change	Andrew Geissler	1	-1/+1
	Yocto upstream moved context and coroutine directly into BOOST_LIBS, which means that they're not added back for our arm variant. https://github.com/lgirdk/poky/commit/624262541605c476f5a0bd415b08d00379c15b00 Temporarily remove our BOOST_LIBS override so we can pull the upstream yocto in, then come back and add specifically what we need again. Tested: None, letting CI verify it (From meta-phosphor rev: 8c30e9b47641854502a31c0a8402d3142586fd55) Change-Id: I4f174a2473525a02e5c5c080ffc90929f5e4770e Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-08-20	Enforce the coding standard usages of boost	Ed Tanous	1	-0/+12
	3 years ago, we pushed a patch to allow the usage of boost libraries, and deleted the phrase "If you give a mouse a cookie". Seemingly, we've done a decent job of not asking for glass of milk, despite the cookie being given. https://github.com/openbmc/docs/commit/56d79455f15ef07be326e59fde4b47ca5866a30c This commit adds some enforcement of this by removing the libraries that are disallowed by the coding standard, and ensuring that only the boost headers are passed through the build. This means that it reduces a large bottleneck in the build, and saves a significant amount of build time (about 5 minutes the last time I measured it). After a discussion a long time ago, it was deemed that coroutine and context would be allowed in, given that they solved a significant problem, and didn't add a large binary size to the image. This patchset preserves those two libraries. I've had this patch locally for a long time to improve my build times; I only remembered it because boost-url broke it given that by default it builds in c++11 mode, which requires boost. As such, I have modified our build of it to build in standalone mode, which relies on c++17 semantics, and does not require boost libraries. This is added as a bbappend, given that it will likely be deleted from meta-phosphor shortly, once we merge in the latest yocto tree, which has accepted it. Tested: Built with the patchset below. obmc-phosphor-image builds in significantly less time, which no sstate cache. (From meta-phosphor rev: 69e46c2f6f94563762c57382f7dfcc6ac84229b5) Signed-off-by: Ed Tanous <ed@tanous.net> Change-Id: I44b849ad395092254a0df84e219e6e78b47625f1 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>