Age | Commit message (Collapse) | Author | Files | Lines |
|
Ali Ahmed (1):
Fix typos in comments
Change-Id: Ifeaede62ba83f55877f9bfb55c0ad2b5ffefc024
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Chris Cain (1):
Control.Power.Mode: Add System Power Mode Interface YAML
Jonathan Doman (1):
Add UniqueIdentifier interface
Patrick Williams (1):
build: minor fix to meson regen script changing
Change-Id: I3e6711e4bb7e5db68523b1cb28280d04c051a664
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Vishwanatha Subbanna (1):
Configs: Rainier: Add led group json for Rainier 1S4U system
Change-Id: I0c67d75a440aa222e8b7a6b24c0bc76ce961432d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: I9748c5ec4f057b8db2d963597d918500f7869d8f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: I7a4c4f81532605e60deee58ab4b2e39e350ad827
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
phosphor-dbus-interfaces: srcrev bump 32fbd5df09..5d0b767aeb
Alpana Kumari (1):
InventoryItemDimm: Change the type of 'MemorySizeInKB'
Andrew Geissler (1):
host: define new interface for checking condition
Patrick Williams (1):
Sensor.Value: add defaults for min/max
phosphor-inventory-manager: srcrev bump 21e72fb2a5..ab1f8b520a
Alpana Kumari (1):
Support Variant Type size_t
Change-Id: I189ab6583b43d36ec58d55c857220fb388799f78
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
It was found that perf(1) had some issues with recording and analysing
data on Rainier systems:
```
root@rainier:~# perf probe --add mem_serial_in
root@rainier:~# perf record -e probe:mem_serial_in -aR sleep 1
[ perf record: Woken up 1 times to write data ]
assertion failed at util/namespaces.c:257
No kallsyms or vmlinux with build-id e4e9c7cff1deb3bf32958039c696f094dc76cf5c was found
[ perf record: Captured and wrote 0.377 MB perf.data (25 samples) ]
root@rainier:~# perf script -v
build id event received for [kernel.kallsyms]: e4e9c7cff1deb3bf32958039c696f094dc76cf5c
broken or missing trace data
incompatible file format (rerun with -v to learn more)
```
Starting with the failed assertion in the recording, we find the
relevant code is the following WARN_ON_ONCE():
```
void nsinfo__mountns_exit(struct nscookie *nc)
{
...
if (nc->oldcwd) {
WARN_ON_ONCE(chdir(nc->oldcwd));
zfree(&nc->oldcwd);
}
```
A strace of `perf record` demonstrates the relevant syscall sequence,
where /home/root is the working directory at the time when `perf record`
is invoked.
```
openat(AT_FDCWD, "/proc/self/ns/mnt", O_RDONLY|O_LARGEFILE) = 12
openat(AT_FDCWD, "/proc/142/ns/mnt", O_RDONLY|O_LARGEFILE) = 13
setns(13, CLONE_NEWNS) = 0
statx(AT_FDCWD, "/mnt/rofs/bin/udevadm", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT, STATX_BASIC_STATS, {stx_mask=STATX_BASIC_STATS|0x1000, stx_attributes=0, stx_mode=S_IFREG|0755, stx_size=978616, ...}) = 0
openat(AT_FDCWD, "/mnt/rofs/bin/udevadm", O_RDONLY|O_LARGEFILE|O_CLOEXEC) = 14
setns(12, CLONE_NEWNS) = 0
chdir("/home/root") = -1 ENOENT (No such file or directory)
```
From the path of the binary, PID 142 is executing in an unanticipated
environment. Its path is representative of the state of the filesystem
prior to the initramfs handing over to /sbin/init in the real root,
suggesting an issue with the initramfs' /init implementation.
In /init we find a bunch of setup to discover and mount the root device.
At the end of the script we prepare for the real root by exec'ing chroot.
From `man 2 chroot`[0]:
```
DESCRIPTION
chroot() changes the root directory of the calling process to that speci‐
fied in path. This directory will be used for pathnames beginning with /.
The root directory is inherited by all children of the calling process.
```
Specifically, this outlines that chroot(2) affects the state of the
calling *process* and not the state of mount namespace in use by the
process.
Further, a call to `setns(..., CLONE_NEWNS)` explicitly replaces the
mount namespace for the *process*, and as such destroys any chroot state
that might have been associated with the process' original mount
namespace. As the chroot state is not a property of a mount namespace,
switching *back* to the application's original mount namespace does not
restore the process' original chroot state.
As such, the chdir(2) from the strace output above returns an error, as
the get_current_dir_name(3) call that yielded the provided path was
issued prior to switching into the target process' mount namespace, and
was thus derived in the chroot context. The path is therefore invalid
once the original mount namespace is restored via the second setns(2) as
the process has (already) lost the chroot context for the original
namespace.
For perf(1) to work in its current implementation the effective root for
PID 1 must remain the absolute path "/" with respect to the kernel's VFS
layer. This requires /init to use either pivot_root(1) or
switch_root(1). pivot_root(1) is ruled out by its own man-page[1]:
```
NOTES
...
The rootfs (initial ramfs) cannot be pivot_root()ed. The recommended
method of changing the root filesystem in this case is to delete every‐
thing in rootfs, overmount rootfs with the new root, attach stdin/std‐
out/stderr to the new /dev/console, and exec the new init(1). Helper pro‐
grams for this process exist; see switch_root(8).
...
```
As noted, the recommendation is a description of the switch_root(8)
application[2]. The details of why the specific sequence for
switch_root(8) is necessary is documented in [3].
Change /init to use switch_root(8) to avoid the nasty interaction of
chroot(2) and setns(2).
[0] https://man7.org/linux/man-pages/man2/chroot.2.html#DESCRIPTION
[1] https://man7.org/linux/man-pages/man2/pivot_root.2.html#NOTES
[2] https://man7.org/linux/man-pages/man8/switch_root.8.html
[3] https://git.busybox.net/busybox/tree/util-linux/switch_root.c?h=1_32_1#n298
Change-Id: Iac29b53a462b03559d18fe9b600aefcd1951057e
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: I4e14b5fb556a03c254253aa3da8cd0ca7b1140b1
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Roland Veloz (1):
pldmbios: Adding a BIOS attribute that can limit the number of cores activated
Change-Id: I64738d5997a677d06755cae141ceb8d8ba1233cc
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Willy Tu (1):
test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD
Change-Id: I010483a6110a394aed137308cf91bdef968bdb2e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Charles Hsu (1):
Add timing configurations into power-config-host0.json
Change-Id: I545d4072ba16c1c27d296cf1c44e6ad7731d8e3c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Pavithra Barithaya (1):
PLDM: Remove Boot Progress entry from 11.json
Change-Id: I9112c4995f62d25f8ef314659133c68be2b3574b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: Ib15357fce19134618d9a1fc1a77472d3af7a078d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Willy Tu (1):
test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD
Change-Id: Iecc9bfbacc31d9e9f3664740aa0110341efd382a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Apply autojson to all existing configurations
Change-Id: Ic370d2239238fb61abb339604ba197d34e19667a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Harvey Wu (1):
Add MaxValue/MinValue setting in config
Patrick Williams (1):
add clamping of min/max
Change-Id: I211e030021d95eeaa8378bd4cdcca4a6f64a90e1
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Shawn McCarney (2):
regulators: Remove SensorReading data type
regulators: Convert to new SensorType enumeration
Change-Id: I4437444e80b5e2a8e4e691ca764d36874021616b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Chicago Duan (1):
Redfish: Fix the health and state properties of processor
Ivan Mikhaylov (1):
bmcweb: fetch ip address on every request in handle
Noah Brewer (1):
Redfish: Update Powering On Status State
Change-Id: If55fa3b7c6725e7f8d1e50e7e1fd1f8eadf5a6f9
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Matt Spinler (1):
docs: Update presence GPIO I2C path
Change-Id: I6ce3b54616276bce9af78f1a3360f5b41b46e5dc
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ravi Teja (2):
CA Certs: Modify object entry path to fix object sub-tree hierarchy
CA Cert: Fix D-bus object path
Change-Id: Ic4e436a9d53a070f0d77e8385b59ccee72ce21bc
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (2):
bootstrap: fix shellcheck warnings
enable shellcheck
Change-Id: I07d94247a32e6d4445ed41a10aeaf60c78ccb824
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: I4e2520684dc4db95c83ea594b0dba5ddbfddc5fa
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Shawn McCarney (3):
regulators: Create DBusSensors class
regulators: Remove Services& from Sensors methods
regulators: Add Sensors to Services hierarchy
Change-Id: I4e071b4b28dd8017221b4ab87813ad751b36a864
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Lei YU (3):
Re-organize internal namespace
Get ignored interfaces from environment
Ignore the interfaces defined in IGNORED_INTERFACES
Change-Id: I61343d73f65bdd89eafc5d187a9a0d03a160e98a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Lei YU (1):
PSUSensor: Add support for inspur-ipsps driver
Zev Weiss (1):
Add Unit property to dbus interfaces
Change-Id: I9c1fcae7d72970ade3d62ca91393173e537ff514
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (3):
build: add wrapfiles for dependencies
build: update to C++20
build: fix dependency check for nlohmann/json
Change-Id: If94ec66c6120627d0333a45f40aa0476d5e9ada9
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Vishwanatha Subbanna (8):
Configs: Everest: Add power supply led groups to group json
Configs: Everest: Add TPM and RTC led groups to group json
Configs: Everest: Add DASD backplane and NVME slot led groups
Configs: Everest: Add planar and bmc led groups to group json
Configs: Everest: Add Operator Panel led groups to group json
Configs: Everest: Add DIMM led groups to group json
Configs: Everest: Add power supply riser card led groups to group json
Configs: Everest: Add OpenCAPI connector led groups to group json
Change-Id: I782e85ac91ef1330024e5b2b74701b2c96860200
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Willy Tu (1):
test: Replace the C++ MOCK_METHOD<n> macros with the new MOCK_METHOD
Change-Id: Ie876d5677d09835bf0a183e1ec155a97028d7673
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
enable shellcheck
Change-Id: I999af524ad9957781d0f2c73d4ca7973e2142ea5
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
bootstrap: fix shellcheck warnings
Change-Id: I069ae8e2e11332c8e2b64ea972f2a5cedad3bdb2
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Fix infinite redirect when webui isn't installed
Change-Id: I5d8fa8a7d042b168b0f9c21204597b8898b4a23a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Venture (1):
MAINTAINERS: Handoff from Venture to Kim
Change-Id: I718c80713a11af7573d6a92c0c43412b8cd8341e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Make object_path operator/ const
Change-Id: I2e60f18ca307614c6fd6b8ad63d6c3ca854c468f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Matt Spinler (1):
json config: Trace when conf files can't be found
Change-Id: I0601976452a5558d1482744f565e3d9b6317cf93
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
George Liu (1):
ledSysfs: Replace IRC with Discord
Change-Id: I112ee6cb4854e7d3b9036b66da299f248fcadd4e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Bruce Lee (1):
Add object manager
Change-Id: I6fee7f7cc9b82fad51c63aacdc9ca88834936e5d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
George Liu (1):
Fix potential map::at error
Tom Joseph (1):
MAINTAINERS: update email for Tom
Zach Clark (1):
Add definitions for Health State state set enumeration values
Change-Id: I30c78636b25ed720ddd49fd29c1404d20a79f3b4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Lei YU (1):
rsyslog-config: Support IPv6 address
Patrick Williams (7):
openpower-pels: src: remove use of VLA
openpower-pels: clean up various compile warnings
logging_test: fix compile warning from oe-sdk
openpower-pels: repository: fix use-after-free
rsyslog-config: fix memory leak in addressValid
test: serialization_test_properties: fix stale stack use
openpower-pels: json_utils: fix crash on invalid format string
Change-Id: I6eeb14c0c34e389d32c25995aab3be9de2ccde10
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Revert "autojson.py: Check the sensor name"
Paul Fertser (1):
autojson.py: add newline character before the end of file
Change-Id: I37466e04f49491a2e54426bb8c7fcc4a0644fb2c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
William A. Kennington III (8):
meson: Fixup formatting
meson: Remove explicit werror override
meson: Propagate watchdog library dependencies
meson: Use subprojects where possible
meson: Add missing CLI11 check and subproject support
meson: Move to c++20
test/watchdog: Remove separate header
Move source into src directory
Change-Id: If6c06b9c1d03241e0952ad3f1fac154e8249ee3c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Brandon Wyman (1):
psu-ng: Call updateInventory() in PSU constructor
Shawn McCarney (1):
regulators: Create DBusSensor class
Change-Id: Ibb6b9a9c858b2db244c9376b66164341dc5fa7ae
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Signed-off-by: Sumit Kumar <sumit_kumar@in.ibm.com>
Change-Id: Ic67ea512753959789e67d3f293714b66b9f5837d
|
|
Andrew Geissler (1):
sched-host-tran: change info trace to debug
Change-Id: I51e4aae2d2b3b08f691a39628ea520eb285ab87a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Patrick Williams (1):
enable shellcheck
Change-Id: I289aa4ea170fd430a37a3dc996bbfd92ce4deb80
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Duke Du (1):
Send high/low alarm signal when sensor reading exceeds threshold
Change-Id: I8c3ecc19329703f84be2a6fde1fd915a6affbae4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zev Weiss (1):
psusensor: add LM25066 support
Change-Id: Ibc6a8c5859ea9be42c6913b27ef44aaabbfd6ab8
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Vernon Mauery (1):
Return channel in get system restart cause
Change-Id: I20abdd4d6fe8d7c74a8fe68dfff1a8f5dc4950de
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Vijay Lobo (1):
PEL: Support user supplied flag to indicate a fatal/terminating
Change-Id: I0afd834c4a9f2d38da5317e60d5ae007bb44b52d
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Igor Kononenko (1):
entity-manager: allow non-numeric substitution for name
Change-Id: I4df4c855ddf76e60f643e2c5f7c930f35b958090
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Przemyslaw Czarnowski (1):
Fix comparison for proxy/legacy mode
Change-Id: If8deb9f86b544e63b07b07aca3449d4b22e7384c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|